Added case for when certificationInstruments inside the getCertificat… #3627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltheism
added
Category: Bug
maltheism
force-pushed
the
clinical_training_empty_certificationInstruments_fix
branch
from
35ddfb2 to
dacb837
Compare
…ionInstruments() function has empty string and fixes console warning
maltheism
force-pushed
the
clinical_training_empty_certificationInstruments_fix
branch
from
dacb837 to
93dcf92
Compare
|
Was this PR supposed to remove the console warning or change it? I am getting a new warning now |
ZainVirani
previously requested changes
May 14, 2018
| "SELECT ID | ||
| FROM test_names | ||
| WHERE Test_name | ||
| LIKE '%$test_key%'" |
There was a problem hiding this comment.
these lines should be aligned with the query, other than that its ready to be approved
ZainVirani
added
the
Passed manual tests
|
Ignore this -- fixed on major |
PapillonMcGill
previously requested changes
May 18, 2018
| = \Utility::toArray($certificationInstruments['test']); | ||
| foreach ($certificationInstruments['test'] as $certificationInstrument) { | ||
| $test_key = $certificationInstrument['@']['value']; | ||
| $testID = $DB->selectOne( |
There was a problem hiding this comment.
This should be pselectOne()
maltheism
dismissed stale reviews from PapillonMcGill and ZainVirani
switched it to pselectOne
PapillonMcGill
approved these changes
May 18, 2018
maltheism
deleted the
clinical_training_empty_certificationInstruments_fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ionInstruments() function has empty string and fixes console warning
This pull request
Fresh install of Loris will output a console warning when going to Clinical->Training. Fixed by checking if the variable $certificationInstruments is a blank string inside the function getCertificationInstruments() and resulting in the warning as no array was created..See also:
Bug #14380