Reports statistics demographic statistics fix #3628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ass.inc in setup() function.
maltheism
added
Category: Bug
johnsaigle
previously approved these changes
May 2, 2018
|
Why does Travis keep not starting on our PRs.. |
ZainVirani
added
the
Passed manual tests
driusan
reviewed
May 23, 2018
| @@ -227,6 +227,11 @@ class Stats_Demographic extends \NDB_Form | |||
| $this->tpl_data['Subprojects'] = $subprojects; | |||
| $this->tpl_data['Visits'] = $Visits; | |||
|
|
|||
| // PREVENT Undefined property Console Output | |||
| if (!isset($this->params)) { | |||
| $this->params = null; | |||
There was a problem hiding this comment.
Why not just define params as a class variable at the start of the class and instantiate it as null so that it's always defined?
There was a problem hiding this comment.
Way better solution, will do!
driusan
previously requested changes
May 28, 2018
| * @var array | ||
| * @access private | ||
| */ | ||
| var $params = null; |
There was a problem hiding this comment.
This is PHP4 style. The @access private should be removed, and use the language level private/protected/public keywords instead of var in the code rather than a comment.
(This should also probably be protected, not private.)
maltheism
dismissed
driusan’s stale review
used language level keywords instead of var
|
LWBTM (look way better to me :-) ) |
driusan
approved these changes
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
Prevents console warning when going to Reports->Statistics and clicking on the Demographic Statistics when using a fresh installed version of Loris. Itbecomes fixed by checking if $params has been set and prevent undefined property..See also:
Bug #14381