[media] unathenticated viewing private data fix #3657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
May 8, 2018 16:31
maltheism
added
Category: Bug
|
Hey @intralizee it looks like you have some unrelated commits on this branch. This will have to be resolved. |
johnsaigle
previously requested changes
May 10, 2018
| * | ||
| * @return void | ||
| */ | ||
| function viewData() |
There was a problem hiding this comment.
Could you move this function declaration to the bottom of the files with the other ones? It feels strange to have the functions in different places
driusan
previously requested changes
May 10, 2018
added 2 commits
May 10, 2018 11:13
maltheism
changed the title
johnsaigle
approved these changes
May 10, 2018
There was a problem hiding this comment.
LGTM. Note that the line
will need to be updated in the major branch to conform with the changes in #3655.
kongtiaowang
added
the
Passed manual tests
PapillonMcGill
approved these changes
May 18, 2018
driusan
approved these changes
May 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
fixes private data from being viewed. Itadds permission check for user accessing the getData in FileUpload.php.See also:
Bug #13847