[InstallDB] Modifying the check to see whether http or https protocol is being used.

[um4r12]

This pull request attempts to determine whether the http or https protocol is being used. It modifies the getBaseURL() function to check if $_SERVER['HTTP_X_FORWARDED_PROTO'] is set to https rather than $_SERVER['HTTPS'].

[johnsaigle]

Perhaps it would be better to check for both? Check first for $_SERVER['HTTPS'] and go to $_SERVER['HTTP_X_FORWARDED_PROTO'] if it fails

[driusan]

It should definitely check for both. HTTP_X_FORWARDED_PROTO is only set if there's a proxy in between the server and PHP (and that proxy is setting the field).. it's not a reliable way to detect the protocol for servers that are directly served by a web server.

[um4r12]

Okay cool, will add that back again. If I were to also add an additional check for server_port (443), is that too much?

[driusan]

I don't know if PHP provides a way to get the server port, but even if it did it wouldn't be reliable since the server could be configured to run on any port for either http or https.

I think

$RequestScheme = 'http';
if (old way of checking || x-forwarded-proto) {
 $RequestSchema = 'https';
}

should handle most configurations.

[ZainVirani]

Script failed on my side, error log sent on slack

I think it failed for a completely unrelated reason. Someone else should test this.

[driusan]

It looks good to me, but any word on @ZainVirani's problem? Has it been (better?) tested?