[Doc Repo] Fix path traversal security issue #3678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsaigle
added
Category: Bug
PapillonMcGill
previously approved these changes
May 22, 2018
|
@PapillonMcGill I agree that a Security label should be created. I'll put it in the LORIS meeting agenda. |
driusan
previously requested changes
May 23, 2018
| @@ -78,6 +78,7 @@ | |||
|
|
|||
|
|
|||
| $target_path = $base_path . $fileBase; | |||
| error_log("Target path is: $target_path"); | |||
There was a problem hiding this comment.
Left over debug statement.. this shouldn't be in the error log.
ZainVirani
approved these changes
May 28, 2018
johnsaigle
added
the
Category: Security
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Redmine #14511.
Related to #3603, which contains a better fix + more significant refactoring.
This PR provides the minimal changes necessary to fix the vulnerability.