[media] Remove unused code #3705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridz1208
added
Cleanup
|
If they're fully converted to react with live filtering, they're unused, otherwise they're used to map the form to the SQL generated to populate the table. |
ZainVirani
approved these changes
Jun 11, 2018
|
@ridz1208 FYI failing our good friend Travis |
miebeers
added
the
Passed manual tests
|
@cmadjar thx, re-running it now |
HenriRabalais
pushed a commit
to HenriRabalais/Loris
that referenced
this pull request
Aug 3, 2018
This removes the validFilters and formToFilter variables which are unused when using React.
HenriRabalais
pushed a commit
to HenriRabalais/Loris
that referenced
this pull request
Aug 13, 2018
This removes the validFilters and formToFilter variables which are unused when using React. [Help Editor] Remove unused 'indent' variable (aces#3757) Added spec/README for conflict resolver module (aces#3375) This adds a README for the conflict resolver outlining the purpose of the module, following the template set out by the imaging_browser module. Added ModalWindow Component to Tabs Added Webpack Config added scroll on Modal Window added functionality to Panel updated composer to be able to use namespaces added containerIndex to webpack added Modal Window and Loader updated ModalWindow Added Modal Window functionality updated Modal Window Updated Modal Window added functionality to form.js Altered Database class to allow on duplicate update update documentation for on duplicate key update edited Form.js Made changes to Modal Window Updated Modal Window Edited Loader and Media Rebased Altered Modal Window and Loader Removed debugging message Made changes to filter form and datatable change loader css Made changes to Form.js and CSS Added error props to Form.js Added JSON Router Dependencies ; Altered Filter Form to Prevent Infinite Loop Recompiled JSX
HenriRabalais
pushed a commit
to HenriRabalais/Loris
that referenced
this pull request
Oct 4, 2018
This removes the validFilters and formToFilter variables which are unused when using React. [Help Editor] Remove unused 'indent' variable (aces#3757) Added spec/README for conflict resolver module (aces#3375) This adds a README for the conflict resolver outlining the purpose of the module, following the template set out by the imaging_browser module. Added ModalWindow Component to Tabs Added Webpack Config added scroll on Modal Window added functionality to Panel updated composer to be able to use namespaces added containerIndex to webpack added Modal Window and Loader updated ModalWindow Added Modal Window functionality updated Modal Window Updated Modal Window added functionality to form.js Altered Database class to allow on duplicate update update documentation for on duplicate key update edited Form.js Made changes to Modal Window Updated Modal Window Edited Loader and Media Rebased Altered Modal Window and Loader Removed debugging message Made changes to filter form and datatable change loader css Made changes to Form.js and CSS Added error props to Form.js Added JSON Router Dependencies ; Altered Filter Form to Prevent Infinite Loop Recompiled JSX
HenriRabalais
pushed a commit
to HenriRabalais/Loris
that referenced
this pull request
Jan 30, 2019
This removes the validFilters and formToFilter variables which are unused when using React. [Help Editor] Remove unused 'indent' variable (aces#3757) Added spec/README for conflict resolver module (aces#3375) This adds a README for the conflict resolver outlining the purpose of the module, following the template set out by the imaging_browser module. Added ModalWindow Component to Tabs Added Webpack Config added scroll on Modal Window added functionality to Panel updated composer to be able to use namespaces added containerIndex to webpack added Modal Window and Loader updated ModalWindow Added Modal Window functionality updated Modal Window Updated Modal Window added functionality to form.js Altered Database class to allow on duplicate update update documentation for on duplicate key update edited Form.js Made changes to Modal Window Updated Modal Window Edited Loader and Media Rebased Altered Modal Window and Loader Removed debugging message Made changes to filter form and datatable change loader css Made changes to Form.js and CSS Added error props to Form.js Added JSON Router Dependencies ; Altered Filter Form to Prevent Infinite Loop Recompiled JSX
HenriRabalais
pushed a commit
to HenriRabalais/Loris
that referenced
this pull request
Jul 18, 2019
This removes the validFilters and formToFilter variables which are unused when using React. [Help Editor] Remove unused 'indent' variable (aces#3757) Added spec/README for conflict resolver module (aces#3375) This adds a README for the conflict resolver outlining the purpose of the module, following the template set out by the imaging_browser module. Added ModalWindow Component to Tabs Added Webpack Config added scroll on Modal Window added functionality to Panel updated composer to be able to use namespaces added containerIndex to webpack added Modal Window and Loader updated ModalWindow Added Modal Window functionality updated Modal Window Updated Modal Window added functionality to form.js Altered Database class to allow on duplicate update update documentation for on duplicate key update edited Form.js Made changes to Modal Window Updated Modal Window Edited Loader and Media Rebased Altered Modal Window and Loader Removed debugging message Made changes to filter form and datatable change loader css Made changes to Form.js and CSS Added error props to Form.js Added JSON Router Dependencies ; Altered Filter Form to Prevent Infinite Loop Recompiled JSX
HenriRabalais
pushed a commit
to HenriRabalais/Loris
that referenced
this pull request
Oct 7, 2019
This removes the validFilters and formToFilter variables which are unused when using React. [Help Editor] Remove unused 'indent' variable (aces#3757) Added spec/README for conflict resolver module (aces#3375) This adds a README for the conflict resolver outlining the purpose of the module, following the template set out by the imaging_browser module. Added ModalWindow Component to Tabs Added Webpack Config added scroll on Modal Window added functionality to Panel updated composer to be able to use namespaces added containerIndex to webpack added Modal Window and Loader updated ModalWindow Added Modal Window functionality updated Modal Window Updated Modal Window added functionality to form.js Altered Database class to allow on duplicate update update documentation for on duplicate key update edited Form.js Made changes to Modal Window Updated Modal Window Edited Loader and Media Rebased Altered Modal Window and Loader Removed debugging message Made changes to filter form and datatable change loader css Made changes to Form.js and CSS Added error props to Form.js Added JSON Router Dependencies ; Altered Filter Form to Prevent Infinite Loop Recompiled JSX
HenriRabalais
pushed a commit
to HenriRabalais/Loris
that referenced
this pull request
Oct 10, 2019
This removes the validFilters and formToFilter variables which are unused when using React. [Help Editor] Remove unused 'indent' variable (aces#3757) Added spec/README for conflict resolver module (aces#3375) This adds a README for the conflict resolver outlining the purpose of the module, following the template set out by the imaging_browser module. Added ModalWindow Component to Tabs Added Webpack Config added scroll on Modal Window added functionality to Panel updated composer to be able to use namespaces added containerIndex to webpack added Modal Window and Loader updated ModalWindow Added Modal Window functionality updated Modal Window Updated Modal Window added functionality to form.js Altered Database class to allow on duplicate update update documentation for on duplicate key update edited Form.js Made changes to Modal Window Updated Modal Window Edited Loader and Media Rebased Altered Modal Window and Loader Removed debugging message Made changes to filter form and datatable change loader css Made changes to Form.js and CSS Added error props to Form.js Added JSON Router Dependencies ; Altered Filter Form to Prevent Infinite Loop Recompiled JSX
zaliqarosli
added a commit
to zaliqarosli/Loris
that referenced
this pull request
Sep 9, 2021
* [JSX/Form.js] Adding sortByValue Option for Selects and SearchableSelects * removed unnecessary lines * [media] Remove unused code (aces#3705) This removes the validFilters and formToFilter variables which are unused when using React. [Help Editor] Remove unused 'indent' variable (aces#3757) Added spec/README for conflict resolver module (aces#3375) This adds a README for the conflict resolver outlining the purpose of the module, following the template set out by the imaging_browser module. Added ModalWindow Component to Tabs Added Webpack Config added scroll on Modal Window added functionality to Panel updated composer to be able to use namespaces added containerIndex to webpack added Modal Window and Loader updated ModalWindow Added Modal Window functionality updated Modal Window Updated Modal Window added functionality to form.js Altered Database class to allow on duplicate update update documentation for on duplicate key update edited Form.js Made changes to Modal Window Updated Modal Window Edited Loader and Media Rebased Altered Modal Window and Loader Removed debugging message Made changes to filter form and datatable change loader css Made changes to Form.js and CSS Added error props to Form.js Added JSON Router Dependencies ; Altered Filter Form to Prevent Infinite Loop Recompiled JSX * Alter Filter Form to avoid stack overflow Alter Modal Window Made minor change to Form.js Made Upgrades to Modal window Updated Static Data Table Edited Modal Window and Attempted to Add Filter Removed filter * updated modal window * Update Modal Window * Added minor changes * Hack to allow data provisioner filtering * made slight change to user class * Added New Exceptions * rebased to major * removed unnecessary changes * updating Biobank * Added new json response * added BadRequest exception and OK response * making this branch functional again * updating Biobank * Updated Form to work with Biobank Module * made change to multiple select to always store data as array * Added ability to map data values * fixed menu filtering and updated biobank schema script * updated Form.js pattern for time to not include seconds * fixed sql patch * first commit * Update Date and Time Elements * Fixed bug in time element * Update biobank script to include comments for containers * Made datatable component instead of purecomponent * updated sql script for biobank * type fix in column name * [JSX/Form.js] Adding sortByValue Option for Selects and SearchableSelects * removed unnecessary lines * [media] Remove unused code (aces#3705) This removes the validFilters and formToFilter variables which are unused when using React. [Help Editor] Remove unused 'indent' variable (aces#3757) Added spec/README for conflict resolver module (aces#3375) This adds a README for the conflict resolver outlining the purpose of the module, following the template set out by the imaging_browser module. Added ModalWindow Component to Tabs Added Webpack Config added scroll on Modal Window added functionality to Panel updated composer to be able to use namespaces added containerIndex to webpack added Modal Window and Loader updated ModalWindow Added Modal Window functionality updated Modal Window Updated Modal Window added functionality to form.js Altered Database class to allow on duplicate update update documentation for on duplicate key update edited Form.js Made changes to Modal Window Updated Modal Window Edited Loader and Media Rebased Altered Modal Window and Loader Removed debugging message Made changes to filter form and datatable change loader css Made changes to Form.js and CSS Added error props to Form.js Added JSON Router Dependencies ; Altered Filter Form to Prevent Infinite Loop Recompiled JSX * Alter Filter Form to avoid stack overflow Alter Modal Window Made minor change to Form.js Made Upgrades to Modal window Updated Static Data Table Edited Modal Window and Attempted to Add Filter Removed filter * updated modal window * Update Modal Window * Added minor changes * Hack to allow data provisioner filtering * made slight change to user class * Added New Exceptions * rebased to major * removed unnecessary changes * updating Biobank * Added new json response * added BadRequest exception and OK response * making this branch functional again * updating Biobank * Updated Form to work with Biobank Module * made change to multiple select to always store data as array * Added ability to map data values * fixed menu filtering and updated biobank schema script * updated Form.js pattern for time to not include seconds * fixed sql patch * Update Date and Time Elements * Fixed bug in time element * Update biobank script to include comments for containers * updated sql script for biobank * fixed issues with csv download and datatable * deleted untracked files * Fiexed date error message * Fixed Datatable functionality * added autoSelect prop which will auotomatically select the dropdown option if there is only one * made changes requested by Krishna * made overrides for CBIGR * Configured raisinbread to work with Biobank * Add 0000* sql * Update drop tables * fixed drop script * modified sql scripts so that they are contained within the biobank module * fixed pagination problems * fixed sql script * Update for new functions * updates for advanced functionality * added external ID api endpoint * updated Modal functionality * introduced Loading Bar * API fixes * API + * [DQT] Fix for Bio Specimens files * [DQT] CBIGR/Biobank include redesigned DQT (#10) * Make LINST slightly better (#15) * candidate_list and datadictbuilder fix * gitignore * update * remove console.log * add fixes from main * Fix public pages missing title * remove unnecessary changes remove unnecessary changes * fix * npm fix * add package-lock for the sake of it Co-authored-by: ridz1208 <ridz_1208@hotmail.com> Co-authored-by: Rida <rida.loris@gmail.com> Co-authored-by: ridz1208 <ridz1208@users.noreply.github.com> Co-authored-by: Loris Admin <hrabalais.mcin@gmail.com> Co-authored-by: Loris Admin <henri.rabalais@mcin.ca> Co-authored-by: Mélanie Legault <melanie.legault2@mcgill.ca> Co-authored-by: Krishna Chatpar <kchatpar@yahoo.com> Co-authored-by: Laetitia Fesselier <laetitia.fesselier@mail.mcgill.ca> Co-authored-by: maltheism <16293415+maltheism@users.noreply.github.com> Co-authored-by: Alizée Bellerose <misotheism@users.noreply.github.com>
zaliqarosli
added a commit
to zaliqarosli/Loris
that referenced
this pull request
Feb 16, 2022
* [JSX/Form.js] Adding sortByValue Option for Selects and SearchableSelects * removed unnecessary lines * [media] Remove unused code (aces#3705) This removes the validFilters and formToFilter variables which are unused when using React. [Help Editor] Remove unused 'indent' variable (aces#3757) Added spec/README for conflict resolver module (aces#3375) This adds a README for the conflict resolver outlining the purpose of the module, following the template set out by the imaging_browser module. Added ModalWindow Component to Tabs Added Webpack Config added scroll on Modal Window added functionality to Panel updated composer to be able to use namespaces added containerIndex to webpack added Modal Window and Loader updated ModalWindow Added Modal Window functionality updated Modal Window Updated Modal Window added functionality to form.js Altered Database class to allow on duplicate update update documentation for on duplicate key update edited Form.js Made changes to Modal Window Updated Modal Window Edited Loader and Media Rebased Altered Modal Window and Loader Removed debugging message Made changes to filter form and datatable change loader css Made changes to Form.js and CSS Added error props to Form.js Added JSON Router Dependencies ; Altered Filter Form to Prevent Infinite Loop Recompiled JSX * Alter Filter Form to avoid stack overflow Alter Modal Window Made minor change to Form.js Made Upgrades to Modal window Updated Static Data Table Edited Modal Window and Attempted to Add Filter Removed filter * updated modal window * Update Modal Window * Added minor changes * Hack to allow data provisioner filtering * made slight change to user class * Added New Exceptions * rebased to major * removed unnecessary changes * updating Biobank * Added new json response * added BadRequest exception and OK response * making this branch functional again * updating Biobank * Updated Form to work with Biobank Module * made change to multiple select to always store data as array * Added ability to map data values * fixed menu filtering and updated biobank schema script * updated Form.js pattern for time to not include seconds * fixed sql patch * first commit * Update Date and Time Elements * Fixed bug in time element * Update biobank script to include comments for containers * Made datatable component instead of purecomponent * updated sql script for biobank * type fix in column name * [JSX/Form.js] Adding sortByValue Option for Selects and SearchableSelects * removed unnecessary lines * [media] Remove unused code (aces#3705) This removes the validFilters and formToFilter variables which are unused when using React. [Help Editor] Remove unused 'indent' variable (aces#3757) Added spec/README for conflict resolver module (aces#3375) This adds a README for the conflict resolver outlining the purpose of the module, following the template set out by the imaging_browser module. Added ModalWindow Component to Tabs Added Webpack Config added scroll on Modal Window added functionality to Panel updated composer to be able to use namespaces added containerIndex to webpack added Modal Window and Loader updated ModalWindow Added Modal Window functionality updated Modal Window Updated Modal Window added functionality to form.js Altered Database class to allow on duplicate update update documentation for on duplicate key update edited Form.js Made changes to Modal Window Updated Modal Window Edited Loader and Media Rebased Altered Modal Window and Loader Removed debugging message Made changes to filter form and datatable change loader css Made changes to Form.js and CSS Added error props to Form.js Added JSON Router Dependencies ; Altered Filter Form to Prevent Infinite Loop Recompiled JSX * Alter Filter Form to avoid stack overflow Alter Modal Window Made minor change to Form.js Made Upgrades to Modal window Updated Static Data Table Edited Modal Window and Attempted to Add Filter Removed filter * updated modal window * Update Modal Window * Added minor changes * Hack to allow data provisioner filtering * made slight change to user class * Added New Exceptions * rebased to major * removed unnecessary changes * updating Biobank * Added new json response * added BadRequest exception and OK response * making this branch functional again * updating Biobank * Updated Form to work with Biobank Module * made change to multiple select to always store data as array * Added ability to map data values * fixed menu filtering and updated biobank schema script * updated Form.js pattern for time to not include seconds * fixed sql patch * Update Date and Time Elements * Fixed bug in time element * Update biobank script to include comments for containers * updated sql script for biobank * fixed issues with csv download and datatable * deleted untracked files * Fiexed date error message * Fixed Datatable functionality * added autoSelect prop which will auotomatically select the dropdown option if there is only one * made changes requested by Krishna * made overrides for CBIGR * Configured raisinbread to work with Biobank * Add 0000* sql * Update drop tables * fixed drop script * modified sql scripts so that they are contained within the biobank module * fixed pagination problems * fixed sql script * Update for new functions * updates for advanced functionality * added external ID api endpoint * updated Modal functionality * introduced Loading Bar * API fixes * API + * [DQT] Fix for Bio Specimens files * [DQT] CBIGR/Biobank include redesigned DQT (#10) * Make LINST slightly better (#15) * candidate_list and datadictbuilder fix * gitignore * update * remove console.log * add fixes from main * Fix public pages missing title * Biobank branch adapted for the new shipment module * updated form and modal * fix * fix errors for make dev to work * reversals * update react files to npm version * revert StaticElement Co-authored-by: ridz1208 <ridz_1208@hotmail.com> Co-authored-by: Rida <rida.loris@gmail.com> Co-authored-by: ridz1208 <ridz1208@users.noreply.github.com> Co-authored-by: Loris Admin <hrabalais.mcin@gmail.com> Co-authored-by: Loris Admin <henri.rabalais@mcin.ca> Co-authored-by: Mélanie Legault <melanie.legault2@mcgill.ca> Co-authored-by: Krishna Chatpar <kchatpar@yahoo.com> Co-authored-by: Laetitia Fesselier <laetitia.fesselier@mail.mcgill.ca> Co-authored-by: maltheism <16293415+maltheism@users.noreply.github.com> Co-authored-by: Alizée Bellerose <misotheism@users.noreply.github.com>
zaliqarosli
added a commit
to zaliqarosli/Loris
that referenced
this pull request
Feb 23, 2022
* [JSX/Form.js] Adding sortByValue Option for Selects and SearchableSelects * removed unnecessary lines * [media] Remove unused code (aces#3705) This removes the validFilters and formToFilter variables which are unused when using React. [Help Editor] Remove unused 'indent' variable (aces#3757) Added spec/README for conflict resolver module (aces#3375) This adds a README for the conflict resolver outlining the purpose of the module, following the template set out by the imaging_browser module. Added ModalWindow Component to Tabs Added Webpack Config added scroll on Modal Window added functionality to Panel updated composer to be able to use namespaces added containerIndex to webpack added Modal Window and Loader updated ModalWindow Added Modal Window functionality updated Modal Window Updated Modal Window added functionality to form.js Altered Database class to allow on duplicate update update documentation for on duplicate key update edited Form.js Made changes to Modal Window Updated Modal Window Edited Loader and Media Rebased Altered Modal Window and Loader Removed debugging message Made changes to filter form and datatable change loader css Made changes to Form.js and CSS Added error props to Form.js Added JSON Router Dependencies ; Altered Filter Form to Prevent Infinite Loop Recompiled JSX * Alter Filter Form to avoid stack overflow Alter Modal Window Made minor change to Form.js Made Upgrades to Modal window Updated Static Data Table Edited Modal Window and Attempted to Add Filter Removed filter * updated modal window * Update Modal Window * Added minor changes * Hack to allow data provisioner filtering * made slight change to user class * Added New Exceptions * rebased to major * removed unnecessary changes * updating Biobank * Added new json response * added BadRequest exception and OK response * making this branch functional again * updating Biobank * Updated Form to work with Biobank Module * made change to multiple select to always store data as array * Added ability to map data values * fixed menu filtering and updated biobank schema script * updated Form.js pattern for time to not include seconds * fixed sql patch * first commit * Update Date and Time Elements * Fixed bug in time element * Update biobank script to include comments for containers * Made datatable component instead of purecomponent * updated sql script for biobank * type fix in column name * [JSX/Form.js] Adding sortByValue Option for Selects and SearchableSelects * removed unnecessary lines * [media] Remove unused code (aces#3705) This removes the validFilters and formToFilter variables which are unused when using React. [Help Editor] Remove unused 'indent' variable (aces#3757) Added spec/README for conflict resolver module (aces#3375) This adds a README for the conflict resolver outlining the purpose of the module, following the template set out by the imaging_browser module. Added ModalWindow Component to Tabs Added Webpack Config added scroll on Modal Window added functionality to Panel updated composer to be able to use namespaces added containerIndex to webpack added Modal Window and Loader updated ModalWindow Added Modal Window functionality updated Modal Window Updated Modal Window added functionality to form.js Altered Database class to allow on duplicate update update documentation for on duplicate key update edited Form.js Made changes to Modal Window Updated Modal Window Edited Loader and Media Rebased Altered Modal Window and Loader Removed debugging message Made changes to filter form and datatable change loader css Made changes to Form.js and CSS Added error props to Form.js Added JSON Router Dependencies ; Altered Filter Form to Prevent Infinite Loop Recompiled JSX * Alter Filter Form to avoid stack overflow Alter Modal Window Made minor change to Form.js Made Upgrades to Modal window Updated Static Data Table Edited Modal Window and Attempted to Add Filter Removed filter * updated modal window * Update Modal Window * Added minor changes * Hack to allow data provisioner filtering * made slight change to user class * Added New Exceptions * rebased to major * removed unnecessary changes * updating Biobank * Added new json response * added BadRequest exception and OK response * making this branch functional again * updating Biobank * Updated Form to work with Biobank Module * made change to multiple select to always store data as array * Added ability to map data values * fixed menu filtering and updated biobank schema script * updated Form.js pattern for time to not include seconds * fixed sql patch * Update Date and Time Elements * Fixed bug in time element * Update biobank script to include comments for containers * updated sql script for biobank * fixed issues with csv download and datatable * deleted untracked files * Fiexed date error message * Fixed Datatable functionality * added autoSelect prop which will auotomatically select the dropdown option if there is only one * made changes requested by Krishna * made overrides for CBIGR * Configured raisinbread to work with Biobank * Add 0000* sql * Update drop tables * fixed drop script * modified sql scripts so that they are contained within the biobank module * fixed pagination problems * fixed sql script * Update for new functions * updates for advanced functionality * added external ID api endpoint * updated Modal functionality * introduced Loading Bar * API fixes * API + * [DQT] Fix for Bio Specimens files * [DQT] CBIGR/Biobank include redesigned DQT (#10) * Make LINST slightly better (#15) * candidate_list and datadictbuilder fix * gitignore * update * remove console.log * add fixes from main * Fix public pages missing title * Biobank branch adapted for the new shipment module * updated form and modal * fix * fix errors for make dev to work * reversals * update react files to npm version * revert StaticElement * update CandidatesExt endpoint Co-authored-by: ridz1208 <ridz_1208@hotmail.com> Co-authored-by: Rida <rida.loris@gmail.com> Co-authored-by: ridz1208 <ridz1208@users.noreply.github.com> Co-authored-by: Loris Admin <hrabalais.mcin@gmail.com> Co-authored-by: Loris Admin <henri.rabalais@mcin.ca> Co-authored-by: Mélanie Legault <melanie.legault2@mcgill.ca> Co-authored-by: Krishna Chatpar <kchatpar@yahoo.com> Co-authored-by: Laetitia Fesselier <laetitia.fesselier@mail.mcgill.ca> Co-authored-by: maltheism <16293415+maltheism@users.noreply.github.com> Co-authored-by: Alizée Bellerose <misotheism@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
validFiltersandformToFiltervariables which seem to be unused when using react@driusan are these actually not used ?