[Candidate_parameters] Update consent doc #3753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaliqarosli
added
Category: Documentation
johnsaigle
approved these changes
Jun 20, 2018
zaliqarosli
added
Cleanup
driusan
reviewed
Jun 21, 2018
| ALTER TABLE consent_info_history ADD COLUMN draw_blood_consent enum('yes','no','not_answered'); | ||
| ALTER TABLE consent_info_history ADD COLUMN draw_blood_consent_date date; | ||
| ALTER TABLE consent_info_history ADD COLUMN draw_blood_consent_withdrawal date; | ||
| INSERT INTO consent (Name, Label) VALUES ('draw_blood_consent', 'Consent to Draw Blood'); |
There was a problem hiding this comment.
Is there already redmine ticket that this needs a front end to configure?
There was a problem hiding this comment.
@driusan i can make one - it was already in the plans for consent PR 3!
There was a problem hiding this comment.
@driusan which branch should it target?
There was a problem hiding this comment.
Most likely minor, I just want to be sure it's not lost. The document is fine like this since that's the current state of things, but we shouldn't be forcing people to use raw SQL and should make sure there's a plan in place to fix it...
There was a problem hiding this comment.
PapillonMcGill
approved these changes
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates all docs to be in line with recent changes made to normalize consent
Separately, i'll also update https://github.com/aces/Loris/wiki/Candidate-Information-Page - done