Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[document_repository] Different Files with Same Name Not Saved Properly #3763

Closed
wants to merge 2 commits into from

Conversation

kongtiaowang
Copy link
Contributor

This pull request adds a category name make a new path to avoid file overwritten.

@kongtiaowang kongtiaowang added the Category: Bug PR or issue that aims to report or fix a bug label Jun 26, 2018
@kongtiaowang kongtiaowang added this to the 20.0.0 milestone Jun 26, 2018
@johnsaigle
Copy link
Contributor

I believe @intralizee is addressing this issue in #3700 so this PR is a duplicate. I think we should go with the other one since many people have reviewed and tested it already.

@driusan
Copy link
Collaborator

driusan commented Jul 3, 2018

I agree with @johnsaigle, the other PR also seems a little more robust (what happens with this one if the same user uploads something twice to the same category? What happens if it's recategorized? Etc.)

@driusan driusan closed this Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug PR or issue that aims to report or fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants