Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Examiner] fix menu doesn't exist with examiner_view permission. #3782

Merged
merged 2 commits into from
Jul 4, 2018
Merged

[Examiner] fix menu doesn't exist with examiner_view permission. #3782

merged 2 commits into from
Jul 4, 2018

Conversation

kongtiaowang
Copy link
Contributor

This pull request fixes the typo in the 0000-00-02-menu.sql
https://redmine.cbrain.mcgill.ca/issues/14847

@kongtiaowang kongtiaowang added Category: Bug PR or issue that aims to report or fix a bug Language: SQL PR or issue that update SQL code labels Jul 4, 2018
@kongtiaowang kongtiaowang added this to the 20.0.0 milestone Jul 4, 2018
davidblader
davidblader reviewed Jul 4, 2018
View reviewed changes
SQL/New_patches/2018-07-04_examiner_menu.sql Outdated
@@ -0,0 +1,2 @@
NSERT INTO LorisMenuPermissions (MenuID, PermID)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing I

@kongtiaowang
Copy link
Contributor Author

@davidblader Good catch!

driusan
driusan approved these changes Jul 4, 2018
View reviewed changes
Copy link
Collaborator

@driusan driusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double checked against the permissions in the schema and examiner_site doesn't exist, so this seems to be correct.

@driusan driusan merged commit 8a335d8 into aces:20.0-release Jul 4, 2018
@zaliqarosli zaliqarosli mentioned this pull request Jul 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidblader davidblader davidblader left review comments

@driusan driusan driusan approved these changes

Assignees
No one assigned
Labels
Category: Bug PR or issue that aims to report or fix a bug Language: SQL PR or issue that update SQL code
Projects
None yet
Milestone
20.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kongtiaowang @driusan @davidblader