cleanup #3784
Merged
cleanup #3784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlecours
added
the
Cleanup
driusan
added
the
Release: Add to release notes
|
Needs to be mentioned in release notes, I think some instruments may use them. |
ZainVirani
approved these changes
Jul 9, 2018
There was a problem hiding this comment.
I agree with @driusan's comment above
Additionally, both of these functions are not currently used in major, so I don't see any reason to require Passed Manual Tests
|
Seems reasonable if it passes Travis |
PapillonMcGill
approved these changes
Jul 16, 2018
ridz1208
added
the
Release: Breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing functions that should not be there.
_checkDate is in Utility anyway.
_checkDateTaken is not used in our code base.