[Conflict Resolver] Enabling Active Candidate and Active Session Check in Query #3792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sruthymathew123
added
the
Category: Bug
sruthymathew123
changed the title
driusan
reviewed
Jul 9, 2018
| @@ -236,7 +236,7 @@ class Conflict_Resolver extends \NDB_Menu_Filter_Form | |||
| LEFT JOIN session ON (flag.SessionID=session.ID) | |||
| LEFT JOIN candidate ON (candidate.CandID=session.CandID) | |||
| LEFT JOIN Project ON (candidate.ProjectID=Project.ProjectID ) | |||
| WHERE 1=1"; | |||
| WHERE 1=1 AND candidate.Active ='Y'"; | |||
There was a problem hiding this comment.
You can take out the 1=1. That's just there to ensure that if filters add "AND" clauses it doesn't become an SQL syntax error but is unnecessary if there's already a WHERE clause in the query.
driusan
reviewed
Jul 9, 2018
| @@ -84,7 +84,7 @@ class Resolved_Conflicts extends \NDB_Menu_Filter | |||
| LEFT JOIN session ON (flag.SessionID=session.ID) | |||
| LEFT JOIN candidate ON (candidate.CandID=session.CandID) | |||
| LEFT JOIN Project ON (candidate.ProjectID=Project.ProjectID ) | |||
| WHERE 1=1"; | |||
| WHERE 1=1 AND candidate.Active ='Y'"; | |||
|
@driusan Done the requested changes. |
|
@sruthymathew123 The dashboard also filter on session.Active = 'Y' |
|
@xlecours Good question. I think we have to consider that also. |
|
@sruthymathew123 |
sruthymathew123
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redmine 14872
Conflict Resolver is pulling results of Inactive Candidates and Inactive Sessions. This leads to one of the reason for IBIS where our conflicts count in dashboard doesn't match with the count in conflict resolver.