[Instrument list] Populate the timepoint tpl_data for modules #3797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlecours
added
Category: Bug
xlecours
changed the title
driusan
reviewed
Jul 10, 2018
| 'TimePoint', | ||
| \TimePoint::singleton($gets['sessionID']) | ||
| ); | ||
| } |
There was a problem hiding this comment.
Does this belong in the module router? Shouldn't it be up to the individual pages/modules whether or not they want to populate these in the request that gets passed to the middleware?
There was a problem hiding this comment.
Yes, I haven't tested it but that looks better to me. (I don't really think those "magic" panels should be in the page decoration middleware at all, it's a relic from main.php. At the minimum they should be a separate middleware that modules need to explicitly add.)
|
Modules need to add the atributes themselves for the candidate profile panel to show data |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix the missing timepoint data in the candidate profile table of the instrument_list module
The ModuleRouteur is now in charge of adding candidate and timepoint objects to the request.
see: RM#