Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dicom archive] Apply filters dicom achive to mri violations #3830

Conversation

xlecours
Copy link
Contributor

This reuse the existing function that intercept the onClick of serieUID to send a postr request instead of a get.

This apply the filter in the mri_violation page instead of just populating the fields.

IBIS reaalllllly want this :)

@xlecours xlecours added Category: Bug PR or issue that aims to report or fix a bug Critical to release PR or issue is key for the release to which it has been assigned [branch] major labels Jul 16, 2018
@xlecours xlecours added this to the 20.0.0 milestone Jul 16, 2018
@davidblader davidblader added the Passed manual tests PR has been successfully tested by at least one peer label Jul 16, 2018
@xlecours xlecours added the State: Needs work PR awaiting additional work by the author to proceed label Jul 17, 2018
@xlecours
Copy link
Contributor Author

I will remove the href attribute since it is not used anymore

forcing cursor pointer
@xlecours xlecours removed the State: Needs work PR awaiting additional work by the author to proceed label Jul 17, 2018
Copy link
Contributor

@davidblader davidblader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still works after href removal

@um4r12 um4r12 requested review from um4r12 and removed request for um4r12 July 23, 2018 16:36
@ridz1208 ridz1208 modified the milestone: 20.0.0 Jul 27, 2018
@ridz1208 ridz1208 merged commit 3b2d3f7 into aces:20.0-release Aug 1, 2018
@xlecours xlecours deleted the apply_filters_dicom_achive_to_mri_violations branch August 4, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug PR or issue that aims to report or fix a bug Critical to release PR or issue is key for the release to which it has been assigned Passed manual tests PR has been successfully tested by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants