Amended the imaging_uploader module test plan. #3845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasbrossard
added
the
Testing
colezweber
approved these changes
Jul 26, 2018
miebeers
approved these changes
Jul 26, 2018
| @@ -9,7 +9,8 @@ | |||
| 4. Ensure that the Browse tab allows searching based on CandID, PSCID, and/or Visit Label. Ensure that the Visit Label | |||
| is a dropdown menu containing all the possible visit labels (taken from the Visit_label column in the session table | |||
| for any Active candidate), and ensure that the CandID and PSCID automatically filter the list of entries in Imaging | |||
| Uploader table on the 'fly', as fields are being filled out. Ensure that 'Clear Filters' button works. | |||
| Uploader table on the 'fly', as fields are being filled out. Make sure that this works no matter the page of the | |||
| result table you are currently on. Ensure that 'Clear Filters' button works. | |||
There was a problem hiding this comment.
Optional change to make it a little clearer:
"Make sure that this works no matter what page of the uploads table you are currently on" or "Make sure that this works no matter what page of results from the query to the uploads table you are currently on"
zaliqarosli
added
the
Passed manual tests
ridz1208
approved these changes
Jul 27, 2018
| @@ -9,7 +9,8 @@ | |||
| 4. Ensure that the Browse tab allows searching based on CandID, PSCID, and/or Visit Label. Ensure that the Visit Label | |||
| is a dropdown menu containing all the possible visit labels (taken from the Visit_label column in the session table | |||
| for any Active candidate), and ensure that the CandID and PSCID automatically filter the list of entries in Imaging | |||
| Uploader table on the 'fly', as fields are being filled out. Ensure that 'Clear Filters' button works. | |||
| Uploader table on the 'fly', as fields are being filled out. Make sure that this works no matter what page of results | |||
| from the query to the uploads table you are currently on. Ensure that 'Clear Filters' button works. | |||
| [Manual Testing] | |||
| 5. Ensure that the 'Upload' tab has the CandID, PSCID, and Visit Label greyed out upon loading. These greyed out fields remain | |||
| as such if the 'Phantom Scans' is set to Yes, and become fillable and required fields if 'Phantom Scans' is set to No. | |||
There was a problem hiding this comment.
please remove the line break before [Manual Testing]
item 6 and 7 should have ending dots for each bullet (same as 12)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test case to validate the incremental search that would not work in certain cases (see https://redmine.cbrain.mcgill.ca/issues/14925)