[Data Team Helper] Ensure test_name is always a string #3909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsaigle
added
Category: Bug
6 tasks
Modify Utility function to always return a string Change function in module to default to a string and return a string instead of null which was causing issues.
Collaborator
|
Note to self: if you click things in the wrong order "Can only approve open pull requests " |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Just ensure that
test_nameis a string. Shouldn't be too controversial.This type coercion is causing issues with #3878 which is why it needs to be fixed.
To test this change...
This shouldn't alter the behaviour of LORIS. I'm not really sure how
data_team_helperworks but it should work the same!