[Docs] Specify Apache 2.4 required in README #3976
Conversation
johnsaigle
changed the title
johnsaigle
added
Cleanup
|
@driusan done! |
README.md
Outdated
| @@ -25,9 +25,9 @@ Please consult the [LORIS Wiki Setup Guide](https://github.com/aces/Loris/wiki/S | |||
| # Prerequisites for Installation | |||
|
|
|||
| * LINUX (supported on Ubuntu 14+ and [CentOS 6.5](https://github.com/aces/Loris/blob/master/README.CentOS6.md)) | |||
There was a problem hiding this comment.
might want to also specify CentOS 7 here since apache 2.4 doesn't work on < 7
There was a problem hiding this comment.
Thanks, didn't know!
There was a problem hiding this comment.
As long as we're on the topic, maybe we should take out the line entirely. LORIS doesn't have any Linux-only dependencies.
johnsaigle
dismissed stale reviews from Jkat, driusan, and HenriRabalais
via
55d3c9b
|
|
||
| <b>Important:</b> | ||
| * If you are upgrading your LORIS, you'll also want to upgrade to both PHP 7.2 and MySQL 5.7. |
There was a problem hiding this comment.
This still seems worth having.
There was a problem hiding this comment.
You don't think it's redundant given that we have a bulleted list of prereqs above?
There was a problem hiding this comment.
But I don't think "Important" is a very good title anymore. "Note" might be more accurate. If you don't specify --no-dev, you just get more dependencies installed.
| * Apache **2.4** or higher | ||
| * MySQL 5.7 | ||
| * PHP <b>7.2</b> or higher | ||
| * Package manager (for LINUX distributions) | ||
| * Composer : should be run with --no-dev option |
There was a problem hiding this comment.
composer is still required. But maybe the line above it about needing a package manager should be removed while we're at it?
There was a problem hiding this comment.
I removed this line because it is basically a duplicate from line 36.
I'll remove the line above.
There was a problem hiding this comment.
It would make more sense to me to keep it here and delete it below, because installing it is still a prerequisite.
README.md
Outdated
| * MySQL 5.7 | ||
| * PHP <b>7.2</b> | ||
| * Apache **2.4** or higher | ||
| * MySQL 5.7 |
There was a problem hiding this comment.
or higher?
Could we also mention MariaDB? even if we haven't tested it fully
There was a problem hiding this comment.
I think @ridz1208 has tested it.
There was a problem hiding this comment.
10.3, I think. @ridz1208 ?
There was a problem hiding this comment.
@ridz1208 The MariaDB version is the only thing preventing this from being merged
Brief summary of changes
Specifiy that Apache 2.4 is required.
Heroku deploy is no longer "new" so that is removed.
This addresses issue...