[Core: Project, ProjectDefault] Add type declarations to function signatures #4053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsaigle
added
Category: Cleanup
paiva
reviewed
Nov 2, 2018
| * in LORIS. | ||
| * | ||
| * PHP Version 5 | ||
| * PHP Version 7 |
Contributor
There was a problem hiding this comment.
That is the minimum version of PHP required to run the code properly. Type declaration require php7.0.
PapillonMcGill
approved these changes
Nov 5, 2018
kongtiaowang
added
the
Passed manual tests
Contributor
|
ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3878 for more details.
These two classes are done together so that their function signatures are compatible.