[Feedback MRI Popup] Don't call functions that don't exist! #4092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsaigle
added
Category: Bug
johnsaigle
changed the title
johnsaigle
changed the title
cmadjar
approved these changes
Nov 19, 2018
There was a problem hiding this comment.
Before when trying to access a feedback MRI popup window when not logged in:
And error log:
[Mon Nov 19 11:13:21.956037 2018] [php7:error] [pid 14341] [client 132.216.237.71:61355] PHP Fatal error: Uncaught Error: Call to undefined method SinglePointLogin::showLoginScreen() in /var/www/loris/htdocs/feedback_mri_popup.php:21\nStack trace:\n#0 {main}\n thrown in /var/www/loris/htdocs/feedback_mri_popup.php on line 21
With the new great changes of @johnsaigle:
All good!!
cmadjar
added
the
Passed manual tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
When an unauthenticated user tries to access the feedback pop up it will now go through proper 401/403 handling instead of quixotically calling functions that do not exist.