[Core: NDB Page and Children] Add return types to function signatures #4139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsaigle
added
Category: Cleanup
johnsaigle
changed the title
johnsaigle
added
the
State: Needs work
johnsaigle
added
the
State: Blocked
Contributor
Author
|
This PR will be easier to deal with when #4073 is merged so I'm adding |
Collaborator
|
Can we close this and reopen it after the next major release? NDB_Page type signature changes will also require the updating of every single instrument file in every project that upgrades, and we already forced people to do that a couple releases ago, so giving them a break might be a good idea. |
driusan
added
the
State: Discussion required
Contributor
Author
|
@driusan Sure that makes sense. This also impacts other classes that are tightly coupled with NDB_Page, such as LorisForm I believe. I'll make a list of the libraries that will be excluded from the 21 release. |
johnsaigle
removed
the
State: Blocked
Contributor
Author
|
Closing for now. Should be re-opened after the LORIS 21 release. |
johnsaigle
removed
the
State: Discussion required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3878 for background.
This PR covers NDB Page and its child classes. They must be updated together because their function signatures all need to match.