[Core: Module] Make debugging more verbose #4162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsaigle
added
Category: Feature
driusan
reviewed
Nov 29, 2018
johnsaigle
added
the
State: Discussion required
1 task
davidblader
removed
Release: Add to release notes
johnsaigle
added
State: Needs work
johnsaigle
removed
the
State: Needs work
davidblader
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
While working on #3881 I kept running into a problem where I would have a bug but all the error log would display was something like
and a generic stack trace. As a result normal PHP errors got swallowed up by the NotFound exception making it very hard to determine what was actually going wrong.
This change logs the entire path that the Module class tries to resolve and also explains what's happening behind the scenes.