New instruments loading module #4229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driusan
force-pushed
the
InstrumentsModule
branch
from
99dc5e9 to
14fb825
Compare
johnsaigle
reviewed
Jan 3, 2019
| and put in the `project/instruments`. | ||
|
|
||
| Individual instruments may contain their own configurations (such | ||
| as requiring tables to be created or lookup tables.) |
There was a problem hiding this comment.
Suggested change
| as requiring tables to be created or lookup tables.) | |
| as requiring tables to be created or lookup tables). |
There was a problem hiding this comment.
should probably apply this again
There was a problem hiding this comment.
I think @PapillonMcGill is correct in this case based on some Googling. It's not a big deal though.
There was a problem hiding this comment.
Google also says that "color" and "neighbor" are correct spelling.
There was a problem hiding this comment.
Yes, as the parenthesis was opened inside a phrase, not to at the beginning of a new phrase, it as to be closed inside the phrase, so before the dot.
Not a big deal, as @johnsaigle mentioned, this is why I just commented, not ask for change.
johnsaigle
added
Category: Feature
2 tasks
driusan
force-pushed
the
InstrumentsModule
branch
from
e26cfc6 to
29eccbd
Compare
driusan
force-pushed
the
InstrumentsModule
branch
from
29eccbd to
d331f8c
Compare
driusan
added
State: Needs work
driusan
force-pushed
the
InstrumentsModule
branch
from
d331f8c to
0b65850
Compare
zaliqarosli
added
State: Needs rebase
driusan
force-pushed
the
InstrumentsModule
branch
from
d5f9245 to
378fcec
Compare
driusan
removed
the
State: Needs rebase
This adds a new "instruments" module which takes the place of what was previously done by NDB_Caller and main.php to load instruments. The module does not do anything but delegate to existing instruments that are in the project directory. To test this: test a variety of instruments after this change, in both LINST and PHP format. There should be no noticeable difference.
It was causing lorisform_parser to break
- Names commentID in ControlPanel to match its parent's - Replaces REQUESTS with variables
driusan
force-pushed
the
InstrumentsModule
branch
from
378fcec to
8866009
Compare
|
@xlecours @zaliqarosli now that this is based on the most recent release and passing Travis can you review/test? |
|
testing works! |
zaliqarosli
added
the
Passed manual tests
zaliqarosli
approved these changes
Jul 17, 2019
zaliqarosli
pushed a commit
to zaliqarosli/Loris
that referenced
this pull request
Aug 28, 2019
This adds a new "instruments" module which takes the place of what was previously done by NDB_Caller and main.php to load instruments. The module does not do anything but delegate to existing instruments that are in the project directory.
driusan
pushed a commit
that referenced
this pull request
Mar 9, 2020
Linst instrument subtests are blank and not able to render its fields. This is because of legacy request variable left over from before PR #4229 that introduced a new instruments loading module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new instrument loading module (named "instruments") in order to handle the loading of instrument files which was done by NDB_Caller. This removes the last remaining place that
main.phpwas used, which can now be deleted.The NDB_Caller is still required for
survey.php, until surveys are also converted into a proper module with its own routing.To test this change...