[SQL] Rename project_rel table and add constraints #4492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridz1208
added
Cleanup
xlecours
previously requested changes
Apr 30, 2019
| @@ -85,7 +85,7 @@ class ProjectDefault extends Project | |||
| } | |||
|
|
|||
| /** | |||
| * Get that project subprojects as defined in the project_rel table | |||
| * Get that project subprojects as defined in the project_subproject_rel table | |||
There was a problem hiding this comment.
This is not accurate. Project default gets all subprojects because it is meant to be used when there is no project
ridz1208
force-pushed
the
2019_04_30_rename_project_rel
branch
2 times, most recently
from
52af2ff to
3a59ab4
Compare
ridz1208
added
the
State: Blocked
|
blocked by #4493 |
ridz1208
force-pushed
the
2019_04_30_rename_project_rel
branch
from
62b0fc9 to
414355d
Compare
|
DO NOT MERGE. its on the wrong base for now |
ridz1208
added
the
State: Needs work
ridz1208
force-pushed
the
2019_04_30_rename_project_rel
branch
from
79b1066 to
b04f545
Compare
ridz1208
removed
the
State: Needs work
phpcs schema foreign key fix fixup
ridz1208
force-pushed
the
2019_04_30_rename_project_rel
branch
from
4a4f218 to
1095fac
Compare
34 tasks
ridz1208
removed
State: Blocked
|
Can you add testing instructions? |
johnsaigle
added
the
Category: Documentation
ridz1208
force-pushed
the
2019_04_30_rename_project_rel
branch
from
8c97b5a to
aee6739
Compare
PapillonMcGill
approved these changes
Jul 22, 2019
zaliqarosli
pushed a commit
to zaliqarosli/Loris
that referenced
this pull request
Aug 28, 2019
This renames the project_rel table to project_subproject_rel to respect the SQLmodeling standards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This renames the
project_reltable toproject_subproject_relto respect the SQLmodeling standardsThis also adds a front-end control to associate subprojects to projects from the project configuration page. (this should simplify testing)
other changes in this PR
Projectandsubprojecttables for integrity