Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue Tracker] Fix javascript console warning multisite user #4852

Merged
merged 1 commit into from
Jun 17, 2019
Merged

[Issue Tracker] Fix javascript console warning multisite user #4852

merged 1 commit into from
Jun 17, 2019

Conversation

driusan
Copy link
Collaborator

@driusan driusan commented Jun 12, 2019

Fix a warning that appears in the javascript console when a user
has multiple sites affiliated.

Fixes #4727.

@driusan
[Issue Tracker] Fix javascript console warning multisite user
90053c9 
Fix a warning that appears in the javascript console when a user
has multiple sites affiliated.

Fixes aces#4727.
@driusan driusan added 21.0.0 Testing Category: Bug PR or issue that aims to report or fix a bug labels Jun 12, 2019
@PapillonMcGill
Copy link
Contributor

@cmadjar @driusan Unable to reproduce original error on Firefox (Mac and 2 different Linux machines) using fully patched (this morning) 21.0-release.
This PR doesn't generate the error but I can't guarantees it fix the issue.

PapillonMcGill
PapillonMcGill approved these changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@PapillonMcGill PapillonMcGill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was finally able to see the error and test that it doesn't show up with this PR.

@PapillonMcGill PapillonMcGill added the Passed manual tests PR has been successfully tested by at least one peer label Jun 17, 2019
@driusan driusan merged commit 964dc7b into aces:21.0-release Jun 17, 2019
@ridz1208 ridz1208 added this to the 21.0.0 milestone Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PapillonMcGill PapillonMcGill PapillonMcGill approved these changes

Assignees

@PapillonMcGill PapillonMcGill

Labels
Category: Bug PR or issue that aims to report or fix a bug Passed manual tests PR has been successfully tested by at least one peer
Projects
None yet
Milestone
21.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@driusan @PapillonMcGill @ridz1208