Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Testing] Remove DB Unit package #4985

Merged
merged 1 commit into from
Jul 24, 2019
Merged

[Testing] Remove DB Unit package #4985

merged 1 commit into from
Jul 24, 2019

Conversation

johnsaigle
Copy link
Contributor

@johnsaigle johnsaigle commented Jul 24, 2019 •
edited
Loading

Brief summary of changes

This PR takes over some of the responsibility of #4433.
It is concerned only with removing the DB Unit package which is blocking PR #4914.

I'm not sure if this will actually worked but Shen says we don't actually use this package and made moves to remove it.

Testing instructions (if applicable)

  1. Travis should succeed. No manual testing necessary.

Links to related tickets (GitHub, Redmine, ...)

@johnsaigle johnsaigle added Cleanup PR or issue introducing/requiring at least one clean-up operation Testing PR contains test plan or automated test code (or config files for Travis) Meta PR does something that organizes, upgrades, or manages the functionality of the codebase labels Jul 24, 2019
@johnsaigle
Copy link
Contributor Author

Seems fine 🤷‍♂

driusan
driusan approved these changes Jul 24, 2019
View reviewed changes
Copy link
Collaborator

@driusan driusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing Travis and not touch non-test code, good enough for me.

@driusan driusan merged commit 01976b9 into aces:minor Jul 24, 2019
@ridz1208 ridz1208 added this to the 21.1.0 milestone Jul 24, 2019
zaliqarosli pushed a commit to zaliqarosli/Loris that referenced this pull request Aug 28, 2019
@johnsaigle @zaliqarosli
[Testing] Remove DBUnit package (aces#4985)
339ca37 
Remove unused DBUnit package from list of dev requirements installed by composer.
@johnsaigle johnsaigle deleted the 190724-RemoveDBUnit branch September 24, 2019 17:14
@ridz1208 ridz1208 modified the milestones: 21.1.0, 22.0.0 Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driusan driusan driusan approved these changes

@kongtiaowang kongtiaowang Awaiting requested review from kongtiaowang

Assignees
No one assigned
Labels
Cleanup PR or issue introducing/requiring at least one clean-up operation Meta PR does something that organizes, upgrades, or manages the functionality of the codebase Testing PR contains test plan or automated test code (or config files for Travis)
Projects
None yet
Milestone
22.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@johnsaigle @driusan @ridz1208