Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php/libraries] Module.class.inc fixes slash bug when including directory for endpoint. #5236

Merged

Conversation

maltheism
Copy link
Member

Brief summary of changes

This bugfix fixes the incorrect slash in front of the class name and such as when including a directory for endpoint php classes.

Example: module/php/endpoints/classnames.class.inc
Instead of the usual module/php/classnames.class.inc

@maltheism maltheism added the Category: Bug PR or issue that aims to report or fix a bug label Sep 20, 2019
Copy link
Contributor

@xlecours xlecours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working fine as long as the namespace follows the file system directory tree.
e.g: from a file is \LORIS\<module> namespace, to load the file D.class.inc in the /modules/<module>/php/A/B/C directory, one should call $d = new A\B\C\D();
And in the D.class.inc file, the should be a namespace LORIS\<module>\A\B\C; line

@driusan driusan merged commit af4babf into aces:minor Sep 23, 2019
@ridz1208 ridz1208 added this to the 21.1.0 milestone Oct 1, 2019
@ridz1208 ridz1208 modified the milestones: 21.1.0, 22.0.0 Nov 1, 2019
@maltheism maltheism deleted the minor_fix_endpoint_spl_autoload_register branch May 24, 2020 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug PR or issue that aims to report or fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants