[Examiner] Fixing Errors while saving the form

[sruthymathew123]

Brief summary of changes

This fixes

• [Examiner] Saving the New Examiner certification details giving 500 error  #5423 (I think this bug is caused as an impact of Add new phan rule PhanMismatchReturn #4914. The phan rule addition changed the behavior of the examiner module a little bit. So I am replacing the Loris Exception with someifcases in the code.
• [Examiner] Edit Examiner Page Broken if Certification Instruments Have Similar Names #5544

Testing instructions (if applicable)

1. Try to create a new examiner and edit the examiner details by just clicking 'Save' with no data or with just one instrument details filled. It will throw 500 error. Check out to this branch and try testing with the same case and see if the issue is resolved

2. Add Certification instruments with similar naming (like BMI, BMI_version_2 etc) and try to load the edit examiner page. It will throw 500 error. Check out to this branch and try testing with the same case and see if the issue is resolved

Links to related tickets (GitHub, Redmine, ...)

[johnsaigle]

I tested the first point and it seems to work (i.e. no 500 error generated). 👍

I guess my VM isn't configured properly to be able to test the second point because there are no Certification Instruments enabled. I'm not totally sure how to set this up because there are no examples in the config files and I'm not sure what is compatible with Raisinbread. I opened an issue for this, #5567.

[sruthymathew123]

@johnsaigle Thank you for testing the first part. I caught the second issue while testing on my VM with IBIS data. We have instruments with similar naming and it failed as the testname checking with LIKE CONCAT('%', :testName, '%')",

[driusan]

@nicolasbrossard you probably have certification set up, can you test the second part of this?

[nicolasbrossard]

@driusan @sruthymathew123 I tested this on my VM (without Sruthy's fix) and I indeed get the 500 error. Page displays fine after I pull Sruthy's branch.

Sruthy: 1 Bug: 0 .

👍