Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update phan to latest version #5762

Closed
wants to merge 2 commits into from
Closed

Update phan to latest version #5762

wants to merge 2 commits into from

Conversation

johnsaigle
Copy link
Contributor

No description provided.

@johnsaigle johnsaigle added Testing PR contains test plan or automated test code (or config files for Travis) Meta PR does something that organizes, upgrades, or manages the functionality of the codebase labels Nov 25, 2019
@johnsaigle johnsaigle changed the base branch from major to master December 3, 2019 17:28
@johnsaigle johnsaigle mentioned this pull request Dec 3, 2019
Closed
@johnsaigle johnsaigle added State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed labels Dec 18, 2019
@johnsaigle
Copy link
Contributor Author

We may as well wait until the next version of phan is released to do this because we need it for #5651

@johnsaigle johnsaigle mentioned this pull request Dec 18, 2019
Merged
@driusan driusan mentioned this pull request Jan 6, 2020
Merged
@driusan
Copy link
Collaborator

driusan commented Jan 6, 2020

superceded by #5891

@driusan driusan closed this Jan 6, 2020
driusan added a commit that referenced this pull request Jan 6, 2020
@driusan
Update phan to the newest version. (#5891)
03c119e 
This updates phan to the latest version. Replaces #5762 (which is updating to an older version of phan that still has problems with PHP 7.4.)

Fixes #5651.
lingma pushed a commit to lingma/Loris that referenced this pull request Jan 6, 2020
@driusan
Update phan to the newest version. (aces#5891)
6fa07e1 
This updates phan to the latest version. Replaces aces#5762 (which is updating to an older version of phan that still has problems with PHP 7.4.)

Fixes aces#5651.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Meta PR does something that organizes, upgrades, or manages the functionality of the codebase State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) Testing PR contains test plan or automated test code (or config files for Travis)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnsaigle @driusan