Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename quatUser & quatPassword to something more descriptive #5785

Merged
merged 7 commits into from
Dec 10, 2019
Merged

Rename quatUser & quatPassword to something more descriptive #5785

merged 7 commits into from
Dec 10, 2019

Conversation

maltheism
Copy link
Member

@maltheism maltheism commented Nov 26, 2019 •
edited by johnsaigle
Loading

Brief summary of changes

The quatUser is now dbUser and the quatPassword is now dbPassword.

Links to related tickets (GitHub, Redmine, ...)

@maltheism maltheism added the Cleanup PR or issue introducing/requiring at least one clean-up operation label Nov 26, 2019
@maltheism maltheism changed the title Rename quatUser and quatPassword to something more descriptive Rename quatUser & quatPassword to something more descriptive Nov 26, 2019
@johnsaigle
Copy link
Contributor

The other username and password are also for the database so I don't know if this name is much better. nothing better is coming to mind right now though.

@johnsaigle
Copy link
Contributor

Also I think this should probably go to major instead of the release branch

driusan
driusan previously requested changes Nov 26, 2019
View reviewed changes
Copy link
Collaborator

@driusan driusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think since it's within a <database> parent tag adminUser and adminPassword would be better for the reasons @johnsaigle mentioned.

@johnsaigle
Copy link
Contributor

Looks good, thanks for the cleanup!

johnsaigle
johnsaigle previously approved these changes Nov 26, 2019
View reviewed changes
@maltheism maltheism requested a review from driusan November 26, 2019 20:40
@driusan driusan changed the base branch from 22.0-release to major November 27, 2019 15:21
@maltheism maltheism changed the base branch from major to 22.0-release November 27, 2019 16:42
@maltheism maltheism changed the base branch from 22.0-release to major November 27, 2019 16:44
@johnsaigle johnsaigle added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Nov 27, 2019
@maltheism maltheism changed the base branch from major to 22.0-release November 28, 2019 20:14
@maltheism maltheism force-pushed the rename_quatUser_quatPassword branch from 162316c to a10aa50 Compare November 28, 2019 20:16
@maltheism maltheism changed the base branch from 22.0-release to major November 28, 2019 20:16
@maltheism maltheism removed the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Nov 28, 2019
@maltheism
Copy link
Member Author

@driusan @johnsaigle I rebased to major.

PapillonMcGill
PapillonMcGill previously approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@PapillonMcGill PapillonMcGill left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make the purpose of this user clear. After resolving conflict.

@johnsaigle johnsaigle added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Dec 2, 2019
@maltheism maltheism removed the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Dec 2, 2019
@maltheism maltheism requested a review from johnsaigle December 2, 2019 20:17
@driusan driusan changed the base branch from major to master December 3, 2019 19:07
@driusan driusan added Release: Breaking changes PR that contains changes that might impact the code or accepted practices of active projects Release: Document at release PR whose changes need to be documented in the wiki (or other documentation) at release labels Dec 10, 2019
@driusan
Copy link
Collaborator

driusan commented Dec 10, 2019

Adding tags because projects will need to update existing settings

driusan
driusan approved these changes Dec 10, 2019
View reviewed changes
Copy link
Collaborator

@driusan driusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect there might be other references straggling around that we won't find until release testing, but this is still a good start to fixing this long-standing annoyance..

@driusan driusan merged commit e24342e into aces:master Dec 10, 2019
@ridz1208 ridz1208 added this to the 23.0.0 milestone Dec 17, 2019
@johnsaigle johnsaigle mentioned this pull request Jan 6, 2020
Closed
@christinerogers christinerogers mentioned this pull request Jan 6, 2020
Closed
@ridz1208 ridz1208 added the Release: Add to release notes PR whose changes should be highlighted in the release notes label Jan 31, 2020
@johnsaigle johnsaigle mentioned this pull request Mar 18, 2020
Merged
@maltheism maltheism deleted the rename_quatUser_quatPassword branch May 24, 2020 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PapillonMcGill PapillonMcGill PapillonMcGill approved these changes

@johnsaigle johnsaigle johnsaigle approved these changes

@driusan driusan driusan approved these changes

@xlecours xlecours Awaiting requested review from xlecours

@ridz1208 ridz1208 Awaiting requested review from ridz1208

Assignees
No one assigned
Labels
Cleanup PR or issue introducing/requiring at least one clean-up operation Release: Add to release notes PR whose changes should be highlighted in the release notes Release: Breaking changes PR that contains changes that might impact the code or accepted practices of active projects Release: Document at release PR whose changes need to be documented in the wiki (or other documentation) at release
Projects
None yet
Milestone
23.0.0
Development

Successfully merging this pull request may close these issues.

Rename quatUser and quatPassword to something more descriptive
6 participants
@maltheism @johnsaigle @driusan @PapillonMcGill @ridz1208 @Misotheism