[Menu] Do not show Data Query Tool menu item with data_dict_view permission #5833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default schema incorrectly added a LorisMenuPermissions item for the Data Query Tool if the user had the data_dict_view permission in the default schema. This removes that line, as the correct permission (according to the code) is the dataquery_view permission (which is separately already included in the default schema.)
driusan
added
Release: Add to release notes
maltheism
approved these changes
Dec 5, 2019
|
why not include a patch? too tricky to remove? |
|
This could be sent out to 21 as well. I have a different PR for 21 that will also need a patch |
PapillonMcGill
approved these changes
Dec 9, 2019
|
@driusan could you at least send a patch for this for master ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default schema incorrectly added a LorisMenuPermissions item for the
Data Query Tool if the user had the data_dict_view permission in the
default schema. This removes that line, as the correct permission
(according to the code) is the dataquery_view permission (which is
separately already included in the default schema. See line 209.)
(Note that I didn't include a patch for existing projects because this is
going to the bug fix release.)