[Dashboard] Fix study progression performance #5887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For long running studies the "study progression" widget on the dashboard was doing an excessive number of queries on the database (one per site per month of the study having been running) which was causing the dashboard to take an excessive amount of time to load. This replaces it with a single query using a GROUP BY, and then massages the data in PHP to the same format.
|
(Note: get_recruitment_line_data probably should get a similar treatment, but the query on that one isn't quite as expensive so it takes seconds instead of minutes to run on my sandbox.) |
PapillonMcGill
approved these changes
Jan 6, 2020
lingma
pushed a commit
to lingma/Loris
that referenced
this pull request
Jan 6, 2020
For long running studies the "study progression" widget on the dashboard was doing an excessive number of queries on the database (one per site per month of the study having been running) which was causing the dashboard to take an excessive amount of time to load. This replaces it with a single query using a GROUP BY, and then massages the data in PHP to the same format.
ridz1208
added
the
Release: Add to release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For long running studies the "study progression" widget on the
dashboard was doing an excessive number of queries on the database
(one per site per month of the study having been running) which
was causing the dashboard to take an excessive amount of time to
load.
This replaces it with a single query using a GROUP BY, and then
massages the data in PHP to the same format.
To test this compare the dashboard/ajax/get_scan_line_data.php results
before and after this change. The JSON returned should be identical, but the
performance should be faster (if there's a large enough amount of data
that the before was noticeably slow to load.).