[Core] Add getLastLogin helper to user class #5899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the query to get the last user login from the dashboard code to the User class, where it more accurately belongs. (This was extracted from aces#5896 where it was necessary because multiple modules use the last login time to determine if something is new.)
johnsaigle
reviewed
Jan 7, 2020
johnsaigle
added
the
Cleanup
driusan
added
the
State: Needs work
driusan
added
Blocking
johnsaigle
reviewed
Jan 8, 2020
| AND userID=:UserID AND Success='Y'", | ||
| array('UserID' => $userID) | ||
| ); | ||
| $last_login = $user->getLastLogin($DB)->format('Y-m-d H:i:s'); |
There was a problem hiding this comment.
Will this cause an error to the effect of "Can't use function 'format' on null" when the function returns null?
There was a problem hiding this comment.
Yes, good catch. I added a hack to handle null and ensure that it's in the same format as the DB was returning for this PR only if it's set, but I'll fix it properly in the modularized widgets PR because work on this one will end up getting lost in the end anyways
johnsaigle
approved these changes
Jan 8, 2020
johnsaigle
reviewed
Jan 8, 2020
| @@ -532,5 +532,32 @@ class User extends UserPermissions | |||
| (string) $this->userInfo['Password_hash'] | |||
| ); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Looks good pending Travis. I have a suspicion that one of the static analysis tools won't like the two new lines here but maybe it doesn't matter.
|
One down, 4 to go.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the query to get the last user login from the
dashboard code to the User class, where it more accurately
belongs.
(This was extracted from #5896 where it was necessary because
multiple modules use the last login time to determine if something
is new.)