Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tools] Enable PHPCS for manage_modules.php #5977

Closed
wants to merge 2 commits into from
Closed

[Tools] Enable PHPCS for manage_modules.php #5977

wants to merge 2 commits into from

Conversation

johnsaigle
Copy link
Contributor

No description provided.

@johnsaigle johnsaigle added the Testing PR contains test plan or automated test code (or config files for Travis) label Jan 29, 2020
@johnsaigle johnsaigle requested a review from driusan January 29, 2020 20:17
function addDir(string $moduledir) {
/**
* Adds a new entry to the `modules` table based on a path supplied in the
* $moduledir parameter.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment isn't right.

It adds any subdirectories under $moduledir that are valid modules to the modules table.

Copy link
Collaborator

@driusan driusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see previous comment

@johnsaigle johnsaigle added State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) State: Needs work PR awaiting additional work by the author to proceed labels Feb 6, 2020
@stale
Copy link

stale bot commented Mar 30, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the State: Stale PR that has had no recent activity, needs to be triaged for review or closure to proceed label Mar 30, 2020
@laemtl laemtl removed State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) State: Stale PR that has had no recent activity, needs to be triaged for review or closure to proceed labels Jun 17, 2020
@laemtl laemtl self-assigned this Jun 17, 2020
@laemtl laemtl removed the State: Needs work PR awaiting additional work by the author to proceed label Jun 17, 2020
@laemtl laemtl self-requested a review June 17, 2020 13:54
@laemtl laemtl added the Passed manual tests PR has been successfully tested by at least one peer label Jun 17, 2020
@laemtl laemtl removed the Passed manual tests PR has been successfully tested by at least one peer label Jun 17, 2020
@laemtl laemtl requested a review from driusan June 17, 2020 13:54
@driusan driusan added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Jun 17, 2020
@laemtl laemtl removed the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Jun 17, 2020
@driusan driusan closed this Jun 17, 2020
@driusan driusan reopened this Jun 17, 2020
@laemtl laemtl added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Jun 25, 2020
@laemtl
Copy link
Contributor

laemtl commented Jun 30, 2020

Replaced by #6787

@laemtl laemtl closed this Jun 30, 2020
driusan pushed a commit that referenced this pull request Jul 21, 2020
spell00 pushed a commit to spell00/Loris that referenced this pull request Aug 13, 2020
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this pull request Jun 15, 2021
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this pull request Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) Testing PR contains test plan or automated test code (or config files for Travis)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants