[Tools] Enable PHPCS for fix_timepoint_date_problems.php #5984
Conversation
johnsaigle
added
the
Testing
johnsaigle
added
the
State: Needs rebase
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
State: Stale
laemtl
removed
State: Needs rebase
|
@driusan This is ready for review |
|
@laemtl just to be sure, when you are approving these are you also testing them ? |
|
@ridz1208 I rebased the code and I made sure PHPCS does not detect any problem. |
|
I tested the script and noticed a Fatal error: Should the return type of |
|
@laemtl yes please change it |
johnsaigle
added
the
State: Needs rebase
laemtl
removed
the
State: Needs rebase
| * display and stop processing if action=help | ||
| */ | ||
| if (empty($argv[1]) || $argv[1] == 'help') { | ||
| fwrite(STDERR, "Usage: \n\n"); |
There was a problem hiding this comment.
This is changing the destination of the error message. It should still be going to stderr if the usage was incorrect.
| * display and stop processing if action=help | ||
| */ | ||
| if (empty($argv[1]) || $argv[1] == 'help') { | ||
| //phpcs:disable |
There was a problem hiding this comment.
We either have to disable PHPCS here or modify the help content so that it's ahrder to read and maintain. Since it's only disabled for this heredoc I think it's a fine thing to ignore. This is a section of the code where PHPCS is not helpful.
|
Replaced by #6798 |
No description provided.