[JSX] Add CSSGrid component type #6090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a CSSGrid component type. A CSSGrid aligns a number of cards (passed as a prop) in a grid. The component takes care of converting the values passed to it into cards with an appropriate title, size and positioning.
driusan
added
Category: Feature
This was referenced Feb 21, 2020
driusan
added
the
Blocking
|
@driusan i am wondering why CSSGrid over Flexbox? |
|
@zaliqarosli flexbox only works in 1 dimension. A grid is like a 2 dimensional flexbox. |
|
I'd say "see https://www.webdesignerdepot.com/2018/09/grid-vs-flexbox-which-should-you-choose/" but the images in that link seem to be broken.. |
zaliqarosli
requested changes
Feb 24, 2020
Co-Authored-By: Zaliqa <zaliqa.rosli@mcin.ca>
zaliqarosli
requested changes
Feb 24, 2020
Co-Authored-By: Zaliqa <zaliqa.rosli@mcin.ca>
zaliqarosli
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a CSSGrid component type. A CSSGrid aligns
a number of cards (passed as a prop) in a grid. The
component takes care of converting the values passed
to it into cards with an appropriate title, size
and positioning.