Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] unittests for NDB_Factory.class.inc #6776

Merged
merged 3 commits into from
Sep 9, 2020
Merged

[Test] unittests for NDB_Factory.class.inc #6776

merged 3 commits into from
Sep 9, 2020

Conversation

AlexandraLivadas
Copy link
Contributor

Brief summary of changes

Unit tests for the NDB_Factory library under php/libraries. This PR aims to complete coverage of this library.

Testing instructions (if applicable)

  1. Run `npm run tests:unit -- --filter NDB_Factory

@AlexandraLivadas AlexandraLivadas added the Testing PR contains test plan or automated test code (or config files for Travis) label Jun 29, 2020
@AlexandraLivadas AlexandraLivadas added the State: Needs work PR awaiting additional work by the author to proceed label Jul 9, 2020
@AlexandraLivadas AlexandraLivadas changed the base branch from master to main July 21, 2020 15:15
@AlexandraLivadas AlexandraLivadas force-pushed the 2020-06-26-unit-NDB_Factory branch from 83cadd8 to 5eaf808 Compare August 3, 2020 17:06
@AlexandraLivadas AlexandraLivadas removed the State: Needs work PR awaiting additional work by the author to proceed label Aug 3, 2020
@AlexandraLivadas AlexandraLivadas marked this pull request as ready for review August 3, 2020 21:10
@AlexandraLivadas AlexandraLivadas added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Aug 13, 2020
@AlexandraLivadas AlexandraLivadas force-pushed the 2020-06-26-unit-NDB_Factory branch from 5223d86 to d926e6d Compare August 13, 2020 17:27
@AlexandraLivadas AlexandraLivadas removed the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Aug 13, 2020
@christinerogers
Copy link
Contributor

@AlexandraLivadas is this awaiting re-review by @kongtiaowang or should it be marked Needs work?

@AlexandraLivadas
Copy link
Contributor Author

Hey @kongtiaowang, do you mind offering review for this PR? Thank you!

kongtiaowang
kongtiaowang approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexandraLivadas AlexandraLivadas force-pushed the 2020-06-26-unit-NDB_Factory branch from e404a80 to c06efaf Compare August 31, 2020 13:52
@driusan driusan merged commit 8e4722b into aces:main Sep 9, 2020
@ridz1208 ridz1208 added this to the 24.0.0 milestone Nov 27, 2020
AlexandraLivadas added a commit to AlexandraLivadas/Loris that referenced this pull request Jun 29, 2021
@AlexandraLivadas
[Test] unittests for NDB_Factory.class.inc (aces#6776)
57933cb 
Add unit tests for NDB_Factory class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kongtiaowang kongtiaowang kongtiaowang approved these changes

Assignees
No one assigned
Labels
Testing PR contains test plan or automated test code (or config files for Travis)
Projects
None yet
Milestone
24.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@AlexandraLivadas @christinerogers @kongtiaowang @driusan @ridz1208