[Tools] delete_candidate CanID Fix #6805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laemtl
added
Release: Add to release notes
driusan
reviewed
Jul 6, 2020
tools/delete_candidate.php
Outdated
| @@ -150,7 +154,7 @@ function showHelp() | |||
| * (second-level relations) should have actions on delete specified in the | |||
| * database schema | |||
| * | |||
| * @param string $CandID Identifying the candidate | |||
| * @param CanID $CandID Identifying the candidate | |||
There was a problem hiding this comment.
Suggested change
| * @param CanID $CandID Identifying the candidate | |
| * @param CandID $CandID Identifying the candidate |
laemtl
force-pushed
the
2020-07-06-delete_candidate_CanID
branch
from
7045719 to
495cd79
Compare
driusan
reviewed
Jul 7, 2020
tools/delete_candidate.php
Outdated
| @@ -18,11 +18,15 @@ | |||
| * @license Loris license | |||
| * @link https://www.github.com/aces/Loris-Trunk/ | |||
| */ | |||
|
|
|||
| use LORIS\StudyEntities\Candidate\CandID; | |||
There was a problem hiding this comment.
I'm pretty sure this needs to go below the autoload require.
There was a problem hiding this comment.
@driusan For my personal knowledge, can you explain a bit why? I will take that into account for future changes.
There was a problem hiding this comment.
I might be mistaken, it might not try autoloading until the class is referenced with "new", but how would the class be loaded if the autoloader hasn't been setup yet?
laemtl
added
Testing
christinerogers
previously requested changes
Jul 7, 2020
laemtl
force-pushed
the
2020-07-06-delete_candidate_CanID
branch
from
495cd79 to
4a83884
Compare
laemtl
removed
Blocking
Co-authored-by: christinerogers <christinerogers@users.noreply.github.com>
ridz1208
approved these changes
Jul 15, 2020
|
Thanks @ridz1208 |
christinerogers
approved these changes
Jul 15, 2020
CamilleBeau
added
the
Passed manual tests
spell00
pushed a commit
to spell00/Loris
that referenced
this pull request
Aug 13, 2020
Fix in delete_candidate.php tool to use the CandID class.
Resolves aces#6757
AlexandraLivadas
pushed a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 15, 2021
Fix in delete_candidate.php tool to use the CandID class.
Resolves aces#6757
AlexandraLivadas
pushed a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 29, 2021
Fix in delete_candidate.php tool to use the CandID class.
Resolves aces#6757
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix in delete_candidate.php tool to use the CandID class.