Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[candidate_profile] Show Consent Summary card iff useConsent Yes #6807

Merged
merged 1 commit into from
Jul 13, 2020
Merged

[candidate_profile] Show Consent Summary card iff useConsent Yes #6807

merged 1 commit into from
Jul 13, 2020

Conversation

zaliqarosli
Copy link
Contributor

Brief summary of changes

Resolves #6680

Testing instructions (if applicable)

  1. In Configurations module, set 'Use consent' config option to Yes.
  2. Navigate to Candidate Profile page from non-admin account and see the consent card there as it should be.
  3. Now, set 'Use Consent' config to 'No'
  4. Refresh the candidate profile page and see that the consent card is no longer there

Link(s) to related issue(s)

@zaliqarosli zaliqarosli added Category: Bug PR or issue that aims to report or fix a bug Area: UI PR or issue related to the user interface labels Jul 6, 2020
@zaliqarosli
Copy link
Contributor Author

@driusan ready for re-review

@driusan
Copy link
Collaborator

driusan commented Jul 7, 2020

@zaliqarosli this is going to the wrong branch, it should be 23.0-release

@driusan driusan added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Jul 7, 2020
@zaliqarosli zaliqarosli changed the base branch from master to 23.0-release July 7, 2020 21:52
@zaliqarosli zaliqarosli force-pushed the 2020-07-06-ShowConsentCardIfUseConsent branch from 843c227 to 1193079 Compare July 7, 2020 21:53
@zaliqarosli zaliqarosli removed the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Jul 7, 2020
@zaliqarosli
Copy link
Contributor Author

@driusan done

@sruthymathew123
Copy link
Contributor

sruthymathew123 commented Jul 13, 2020 •
edited
Loading

Tested as per the testing instructions and passes the manual test.

@sruthymathew123 sruthymathew123 added the Passed manual tests PR has been successfully tested by at least one peer label Jul 13, 2020
@driusan driusan merged commit 28d4a14 into aces:23.0-release Jul 13, 2020
@ridz1208 ridz1208 added this to the 23.0.2 milestone Jul 15, 2020
spell00 pushed a commit to spell00/Loris that referenced this pull request Aug 13, 2020
@zaliqarosli @spell00
[candidate_profile] Show Consent Summary card iff useConsent Yes (ace…
69afebf 
…s#6807)

Resolves aces#6680
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this pull request Jun 15, 2021
@zaliqarosli @AlexandraLivadas
[candidate_profile] Show Consent Summary card iff useConsent Yes (ace…
eb95b28 
…s#6807)

Resolves aces#6680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driusan driusan driusan left review comments

@sruthymathew123 sruthymathew123 sruthymathew123 approved these changes

Assignees

@sruthymathew123 sruthymathew123

Labels
Area: UI PR or issue related to the user interface Category: Bug PR or issue that aims to report or fix a bug Passed manual tests PR has been successfully tested by at least one peer
Projects
None yet
Milestone
23.0.2
Development

Successfully merging this pull request may close these issues.

[candidate_parameters] Consent card visible in candidate_profile
4 participants
@zaliqarosli @driusan @sruthymathew123 @ridz1208