[timepoint_list] Hiding Candidate Info and View Imaging Datasets buttons #6815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CamilleBeau
added
Category: Bug
|
@CamilleBeau I think this is supposed to go to the 23.0-release branch for a bugfix, the issue has the 23.0 tag on it.. |
driusan
added
the
State: Needs rebase
CamilleBeau
force-pushed
the
2020_07_06_timepoint_list_button_permissions
branch
from
42e6fdc to
6958c19
Compare
CamilleBeau
removed
the
State: Needs rebase
jesscall
approved these changes
Jul 13, 2020
|
Looks good! With only data entry permission: With only imaging permission: With both: |
jesscall
added
the
Passed manual tests
spell00
pushed a commit
to spell00/Loris
that referenced
this pull request
Aug 13, 2020
…ons (aces#6815) This hides the "Candidate Info" and "View Imaging Datasets" buttons along with the "Create time point" button when the necessary permissions are not present. This was done with the assumption that "View Imaging Datasets" should only be visible if the user has one of the four imaging browser permissions (please correct me if this assumption is wrong). Test plan documentation was edited accordingly. If the user has none of the relevant permissions, the "Actions:" label is also hidden. Resolves aces#6673
AlexandraLivadas
pushed a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 15, 2021
…ons (aces#6815) This hides the "Candidate Info" and "View Imaging Datasets" buttons along with the "Create time point" button when the necessary permissions are not present. This was done with the assumption that "View Imaging Datasets" should only be visible if the user has one of the four imaging browser permissions (please correct me if this assumption is wrong). Test plan documentation was edited accordingly. If the user has none of the relevant permissions, the "Actions:" label is also hidden. Resolves aces#6673
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR hides the "Candidate Info" and "View Imaging Datasets" buttons along with the "Create time point" button when the necessary permissions are not present. This was done with the assumption that "View Imaging Datasets" should only be visible if the user has one of the four imaging browser permissions (please correct me if this assumption is wrong). Test plan documentation was edited accordingly. If the user has none of the relevant permissions, the "Actions:" label is also hidden.
Testing instructions (if applicable)
data_entrypermission. There should be an "Actions:" label as well as the two buttons "Candidate Info" and "Create time point".data_entrypermission).Link(s) to related issue(s)