[Test] unittests for NDB_BVL_Instrument library #6819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandraLivadas
added
Testing
AlexandraLivadas
changed the title
AlexandraLivadas
force-pushed
the
2020-07-03-unit-NDB_BVL_Instrument
branch
from
c5df64c to
c3949f6
Compare
AlexandraLivadas
force-pushed
the
2020-07-03-unit-NDB_BVL_Instrument
branch
from
65fef69 to
5570e09
Compare
AlexandraLivadas
removed
the
State: Needs work
driusan
pushed a commit
that referenced
this pull request
Aug 12, 2020
The unit tests for NDB_BVL_Instrument that were merged with main in PR #6819 were causing Travis to fail. This fixes those errors. The reason it failed Travis was because the changes made in merged PR #5352 were not added to the testing PR. These changes caused it to fail Travis but were not flagged before.
AlexandraLivadas
added a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 15, 2021
Unit tests for the NDB_BVL_Instrument library under php/libraries.
AlexandraLivadas
added a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 15, 2021
The unit tests for NDB_BVL_Instrument that were merged with main in PR aces#6819 were causing Travis to fail. This fixes those errors. The reason it failed Travis was because the changes made in merged PR aces#5352 were not added to the testing PR. These changes caused it to fail Travis but were not flagged before.
AlexandraLivadas
added a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 29, 2021
Unit tests for the NDB_BVL_Instrument library under php/libraries.
AlexandraLivadas
added a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 29, 2021
The unit tests for NDB_BVL_Instrument that were merged with main in PR aces#6819 were causing Travis to fail. This fixes those errors. The reason it failed Travis was because the changes made in merged PR aces#5352 were not added to the testing PR. These changes caused it to fail Travis but were not flagged before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests for the NDB_BVL_Instrument library under
php/libraries. This PR aims to complete coverage for this library.Testing instructions
npm run tests:unit -- --filter NDB_BVL_Instrument_Testor check out the Travis output