Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test/Tools] Option in run-php-linter.sh to auto fix PHPCS #6825

Merged
merged 1 commit into from
Jan 18, 2021
Merged

[Test/Tools] Option in run-php-linter.sh to auto fix PHPCS #6825

merged 1 commit into from
Jan 18, 2021

Conversation

laemtl
Copy link
Contributor

@laemtl laemtl commented Jul 9, 2020 •
edited
Loading

PHPCBF can auto-fix minor PHPCS lint issues (trailing spaces, indent spaces, short arrays notation), which can be convenient.
An es-lint auto-fixer script already exists on the js side (npm lintfix:javascript).
I extended run-php-linter.sh to automatically solve hundred of errors for a recent PR (#6786).

This PR:

  • add a -f flag to run-php-linter.sh, to run PHPCBF in place of PHPCS with the defined rules.
  • add a npm script lintfix:php

To test

  • make sure npm run lintfix:php run `PHPCBF and fixes fixable errors in php files.
  • make sure run-php-linter.sh (make checkstatic) stills works as intended.

Resolves #6826

@laemtl laemtl force-pushed the 2020-07-08-lintfix-php branch from 85e6819 to 5022434 Compare July 9, 2020 18:49
@laemtl laemtl added Cleanup PR or issue introducing/requiring at least one clean-up operation Proposal PR or issue suggesting an improvement that can be accepted, rejected or altered Testing PR contains test plan or automated test code (or config files for Travis) labels Jul 9, 2020
@laemtl
Copy link
Contributor Author

laemtl commented Jul 9, 2020 •
edited
Loading

Example:

FILE: /var/www/html/loris/test/unittests/Database_Test.php
---------------------------------------------------------------------------------------------------------------
FOUND 518 ERRORS AFFECTING 478 LINES
---------------------------------------------------------------------------------------------------------------
   22 | ERROR | [ ] Missing @license tag in class comment
   25 | ERROR | [ ] Missing doc comment for function __construct()
   30 | ERROR | [ ] Missing doc comment for class FakeDatabase
   32 | ERROR | [ ] Missing doc comment for function trackChanges()
   33 | ERROR | [x] Whitespace found at end of line
   34 | ERROR | [x] Whitespace found at end of line
   35 | ERROR | [x] Whitespace found at end of line
   68 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space
   69 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space
  120 | ERROR | [x] Short array syntax must be used to define arrays
  121 | ERROR | [x] Short array syntax must be used to define arrays
  122 | ERROR | [x] Array double arrow not aligned correctly; expected 7 space(s) but found 1
  123 | ERROR | [x] Array key not indented correctly; expected 20 spaces but found 16
  124 | ERROR | [x] Array key not indented correctly; expected 20 spaces but found 16
  124 | ERROR | [x] Array double arrow not aligned correctly; expected 4 space(s) but found 2
  125 | ERROR | [x] Array close brace not indented correctly; expected 16 spaces but found 12
  129 | ERROR | [x] Short array syntax must be used to define arrays
  133 | ERROR | [x] Short array syntax must be used to define arrays
  134 | ERROR | [x] Short array syntax must be used to define arrays
  135 | ERROR | [x] Array double arrow not aligned correctly; expected 7 space(s) but found 1
  137 | ERROR | [x] Array double arrow not aligned correctly; expected 4 space(s) but found 1
  141 | ERROR | [x] Whitespace found at end of line
  152 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 3 spaces
  153 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space
  154 | ERROR | [x] Short array syntax must be used to define arrays
  157 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space
  158 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
  161 | ERROR | [x] Short array syntax must be used to define arrays
  166 | ERROR | [x] Short array syntax must be used to define arrays
  166 | ERROR | [x] Short array syntax must be used to define arrays
  178 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 3 spaces
  179 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space
  180 | ERROR | [x] Short array syntax must be used to define arrays
  184 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space
  185 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
  188 | ERROR | [x] Short array syntax must be used to define arrays
  193 | ERROR | [x] Short array syntax must be used to define arrays
  193 | ERROR | [x] Short array syntax must be used to define arrays
  205 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 3 spaces
  206 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space
  207 | ERROR | [x] Short array syntax must be used to define arrays
  210 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space
  211 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
  214 | ERROR | [x] Short array syntax must be used to define arrays
  219 | ERROR | [x] Short array syntax must be used to define arrays
  219 | ERROR | [x] Short array syntax must be used to define arrays
  231 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 3 spaces
  232 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space
  233 | ERROR | [x] Short array syntax must be used to define arrays
  237 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space
  238 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
  241 | ERROR | [x] Short array syntax must be used to define arrays
  246 | ERROR | [x] Short array syntax must be used to define arrays
  246 | ERROR | [x] Short array syntax must be used to define arrays
  261 | ERROR | [x] Short array syntax must be used to define arrays
  262 | ERROR | [x] Short array syntax must be used to define arrays
  263 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  264 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  266 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  268 | ERROR | [x] Short array syntax must be used to define arrays
  269 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  270 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  272 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  279 | ERROR | [x] Short array syntax must be used to define arrays
  282 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
  282 | ERROR | [x] Short array syntax must be used to define arrays
  287 | ERROR | [x] Short array syntax must be used to define arrays
  288 | ERROR | [x] Short array syntax must be used to define arrays
  289 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  290 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  292 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  297 | ERROR | [x] Whitespace found at end of line
  309 | ERROR | [x] Short array syntax must be used to define arrays
  310 | ERROR | [x] Short array syntax must be used to define arrays
  311 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  312 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  314 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  316 | ERROR | [x] Short array syntax must be used to define arrays
  317 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  318 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  320 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  326 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
  326 | ERROR | [x] Short array syntax must be used to define arrays
  329 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
  329 | ERROR | [x] Short array syntax must be used to define arrays
  334 | ERROR | [x] Short array syntax must be used to define arrays
  335 | ERROR | [x] Short array syntax must be used to define arrays
  336 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  337 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  339 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  358 | ERROR | [x] Short array syntax must be used to define arrays
  359 | ERROR | [x] Short array syntax must be used to define arrays
  360 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  361 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  363 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  365 | ERROR | [x] Short array syntax must be used to define arrays
  366 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  367 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  369 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  374 | ERROR | [x] Whitespace found at end of line
  375 | ERROR | [x] Short array syntax must be used to define arrays
  376 | ERROR | [x] Short array syntax must be used to define arrays
  379 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
  379 | ERROR | [x] Short array syntax must be used to define arrays
  384 | ERROR | [x] Short array syntax must be used to define arrays
  385 | ERROR | [x] Short array syntax must be used to define arrays
  386 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  387 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  389 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  391 | ERROR | [x] Short array syntax must be used to define arrays
  392 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  393 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  395 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  412 | ERROR | [x] Short array syntax must be used to define arrays
  413 | ERROR | [x] Short array syntax must be used to define arrays
  414 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  415 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  417 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  419 | ERROR | [x] Short array syntax must be used to define arrays
  420 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  421 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  423 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  428 | ERROR | [x] Whitespace found at end of line
  429 | ERROR | [x] Short array syntax must be used to define arrays
  429 | ERROR | [x] Whitespace found at end of line
  430 | ERROR | [x] Short array syntax must be used to define arrays
  433 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
  433 | ERROR | [x] Short array syntax must be used to define arrays
  438 | ERROR | [x] Short array syntax must be used to define arrays
  439 | ERROR | [x] Short array syntax must be used to define arrays
  440 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  441 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  443 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  445 | ERROR | [x] Short array syntax must be used to define arrays
  446 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  447 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  449 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  467 | ERROR | [x] Short array syntax must be used to define arrays
  468 | ERROR | [x] Short array syntax must be used to define arrays
  469 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  470 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  472 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  478 | ERROR | [x] Short array syntax must be used to define arrays
  479 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  480 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  481 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  486 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
  486 | ERROR | [x] Short array syntax must be used to define arrays
  491 | ERROR | [x] Short array syntax must be used to define arrays
  492 | ERROR | [x] Short array syntax must be used to define arrays
  493 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  494 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  496 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  498 | ERROR | [x] Short array syntax must be used to define arrays
  499 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  500 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  502 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  519 | ERROR | [x] Short array syntax must be used to define arrays
  520 | ERROR | [x] Short array syntax must be used to define arrays
  521 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  522 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  524 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  530 | ERROR | [x] Short array syntax must be used to define arrays
  531 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  532 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  533 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  538 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
  538 | ERROR | [x] Short array syntax must be used to define arrays
  543 | ERROR | [x] Short array syntax must be used to define arrays
  544 | ERROR | [x] Short array syntax must be used to define arrays
  545 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  546 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  548 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  550 | ERROR | [x] Short array syntax must be used to define arrays
  551 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  552 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  554 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  572 | ERROR | [x] Short array syntax must be used to define arrays
  573 | ERROR | [x] Short array syntax must be used to define arrays
  574 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  575 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  577 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  583 | ERROR | [x] Short array syntax must be used to define arrays
  584 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  585 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  586 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  592 | ERROR | [x] Short array syntax must be used to define arrays
  593 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  594 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  595 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  600 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
  600 | ERROR | [x] Short array syntax must be used to define arrays
  605 | ERROR | [x] Short array syntax must be used to define arrays
  606 | ERROR | [x] Short array syntax must be used to define arrays
  607 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  608 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  610 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  612 | ERROR | [x] Short array syntax must be used to define arrays
  613 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  614 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  616 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  633 | ERROR | [x] Short array syntax must be used to define arrays
  634 | ERROR | [x] Short array syntax must be used to define arrays
  635 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  636 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  638 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  644 | ERROR | [x] Short array syntax must be used to define arrays
  645 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  646 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  647 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  653 | ERROR | [x] Short array syntax must be used to define arrays
  654 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  655 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  656 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  661 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
  661 | ERROR | [x] Short array syntax must be used to define arrays
  666 | ERROR | [x] Short array syntax must be used to define arrays
  667 | ERROR | [x] Short array syntax must be used to define arrays
  668 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  669 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  671 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  673 | ERROR | [x] Short array syntax must be used to define arrays
  674 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  675 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  677 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  694 | ERROR | [x] Short array syntax must be used to define arrays
  695 | ERROR | [x] Short array syntax must be used to define arrays
  696 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  697 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  699 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  705 | ERROR | [x] Short array syntax must be used to define arrays
  706 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  707 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  708 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  714 | ERROR | [x] Short array syntax must be used to define arrays
  715 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  716 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  717 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  717 | ERROR | [x] Whitespace found at end of line
  722 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
  722 | ERROR | [x] Short array syntax must be used to define arrays
  727 | ERROR | [x] Short array syntax must be used to define arrays
  728 | ERROR | [x] Short array syntax must be used to define arrays
  729 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  730 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  732 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  734 | ERROR | [x] Short array syntax must be used to define arrays
  735 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  736 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  738 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  753 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 3 spaces
  754 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space
  756 | ERROR | [x] Short array syntax must be used to define arrays
  761 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space
  762 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
  765 | ERROR | [x] Short array syntax must be used to define arrays
  771 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
  771 | ERROR | [x] Short array syntax must be used to define arrays
  771 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
  771 | ERROR | [x] Short array syntax must be used to define arrays
  783 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 3 spaces
  784 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space
  786 | ERROR | [x] Short array syntax must be used to define arrays
  791 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space
  794 | ERROR | [x] Short array syntax must be used to define arrays
  800 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
  800 | ERROR | [x] Short array syntax must be used to define arrays
  800 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
  800 | ERROR | [x] Short array syntax must be used to define arrays
  814 | ERROR | [x] Short array syntax must be used to define arrays
  815 | ERROR | [x] Short array syntax must be used to define arrays
  816 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  817 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  819 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  825 | ERROR | [x] Short array syntax must be used to define arrays
  826 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  827 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  828 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  845 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 3 spaces
  846 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space
  847 | ERROR | [x] Short array syntax must be used to define arrays
  850 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space
  865 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 3 spaces
  866 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space
  867 | ERROR | [x] Short array syntax must be used to define arrays
  870 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space
  889 | ERROR | [x] Short array syntax must be used to define arrays
  890 | ERROR | [x] Short array syntax must be used to define arrays
  891 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  892 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  894 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  896 | ERROR | [x] Short array syntax must be used to define arrays
  897 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  898 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  900 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  904 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space
  910 | ERROR | [x] Short array syntax must be used to define arrays
  915 | ERROR | [x] Short array syntax must be used to define arrays
  916 | ERROR | [x] Short array syntax must be used to define arrays
  917 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  918 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  920 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  937 | ERROR | [x] Short array syntax must be used to define arrays
  938 | ERROR | [x] Short array syntax must be used to define arrays
  939 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  940 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  942 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  946 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space
  951 | ERROR | [x] Short array syntax must be used to define arrays
  952 | ERROR | [x] Short array syntax must be used to define arrays
  954 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space
  955 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
  955 | ERROR | [x] Short array syntax must be used to define arrays
  960 | ERROR | [x] Short array syntax must be used to define arrays
  961 | ERROR | [x] Short array syntax must be used to define arrays
  962 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
  963 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
  965 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
  969 | ERROR | [x] Short array syntax must be used to define arrays
  981 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 3 spaces
  982 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space
  983 | ERROR | [x] Short array syntax must be used to define arrays
  985 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space
  986 | ERROR | [x] Short array syntax must be used to define arrays
  991 | ERROR | [x] Short array syntax must be used to define arrays
 1003 | ERROR | [x] Short array syntax must be used to define arrays
 1004 | ERROR | [x] Short array syntax must be used to define arrays
 1005 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
 1006 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
 1008 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
 1010 | ERROR | [x] Short array syntax must be used to define arrays
 1011 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
 1012 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
 1014 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
 1020 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
 1020 | ERROR | [x] Short array syntax must be used to define arrays
 1035 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 3 spaces
 1036 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space
 1037 | ERROR | [x] Short array syntax must be used to define arrays
 1040 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space
 1041 | ERROR | [x] Short array syntax must be used to define arrays
 1061 | ERROR | [x] Short array syntax must be used to define arrays
 1062 | ERROR | [x] Short array syntax must be used to define arrays
 1063 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
 1064 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
 1066 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
 1068 | ERROR | [x] Short array syntax must be used to define arrays
 1069 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
 1070 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
 1072 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
 1080 | ERROR | [x] Short array syntax must be used to define arrays
 1086 | ERROR | [x] Short array syntax must be used to define arrays
 1087 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
 1088 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
 1090 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
 1104 | ERROR | [x] Short array syntax must be used to define arrays
 1105 | ERROR | [x] Short array syntax must be used to define arrays
 1106 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
 1107 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
 1109 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
 1111 | ERROR | [x] Short array syntax must be used to define arrays
 1112 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
 1113 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
 1115 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
 1122 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
 1122 | ERROR | [x] Short array syntax must be used to define arrays
 1135 | ERROR | [x] Short array syntax must be used to define arrays
 1136 | ERROR | [x] Short array syntax must be used to define arrays
 1137 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
 1138 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
 1140 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
 1142 | ERROR | [x] Short array syntax must be used to define arrays
 1143 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
 1144 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
 1146 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
 1152 | ERROR | [x] Short array syntax must be used to define arrays
 1155 | ERROR | [x] Short array syntax must be used to define arrays
 1168 | ERROR | [x] Short array syntax must be used to define arrays
 1169 | ERROR | [x] Short array syntax must be used to define arrays
 1170 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
 1171 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
 1173 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
 1175 | ERROR | [x] Short array syntax must be used to define arrays
 1176 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
 1177 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
 1179 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
 1184 | ERROR | [x] Short array syntax must be used to define arrays
 1196 | ERROR | [x] Short array syntax must be used to define arrays
 1197 | ERROR | [x] Short array syntax must be used to define arrays
 1198 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
 1199 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
 1201 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
 1203 | ERROR | [x] Short array syntax must be used to define arrays
 1204 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
 1205 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
 1207 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
 1214 | ERROR | [x] Short array syntax must be used to define arrays
 1280 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 3 spaces
 1281 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space
 1282 | ERROR | [x] Short array syntax must be used to define arrays
 1286 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space
 1286 | ERROR | [x] Short array syntax must be used to define arrays
 1302 | ERROR | [x] Short array syntax must be used to define arrays
 1303 | ERROR | [x] Short array syntax must be used to define arrays
 1304 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
 1305 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
 1307 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
 1309 | ERROR | [x] Short array syntax must be used to define arrays
 1310 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
 1311 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
 1313 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
 1320 | ERROR | [x] Short array syntax must be used to define arrays
 1326 | ERROR | [x] Short array syntax must be used to define arrays
 1327 | ERROR | [x] Short array syntax must be used to define arrays
 1328 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
 1329 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
 1331 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
 1333 | ERROR | [x] Short array syntax must be used to define arrays
 1334 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
 1335 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
 1337 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
 1352 | ERROR | [x] Short array syntax must be used to define arrays
 1353 | ERROR | [x] Short array syntax must be used to define arrays
 1354 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
 1355 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
 1357 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
 1363 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
 1363 | ERROR | [x] Short array syntax must be used to define arrays
 1363 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
 1377 | ERROR | [x] Short array syntax must be used to define arrays
 1378 | ERROR | [x] Short array syntax must be used to define arrays
 1379 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
 1380 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
 1382 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
 1388 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
 1388 | ERROR | [x] Short array syntax must be used to define arrays
 1388 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
 1402 | ERROR | [x] Short array syntax must be used to define arrays
 1403 | ERROR | [x] Short array syntax must be used to define arrays
 1404 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
 1405 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
 1407 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
 1409 | ERROR | [x] Short array syntax must be used to define arrays
 1410 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
 1411 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
 1413 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
 1419 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
 1419 | ERROR | [x] Short array syntax must be used to define arrays
 1419 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
 1424 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
 1424 | ERROR | [x] Short array syntax must be used to define arrays
 1437 | ERROR | [x] Short array syntax must be used to define arrays
 1438 | ERROR | [x] Short array syntax must be used to define arrays
 1439 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
 1440 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
 1442 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
 1444 | ERROR | [x] Short array syntax must be used to define arrays
 1445 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
 1446 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
 1448 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
 1455 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
 1455 | ERROR | [x] Short array syntax must be used to define arrays
 1455 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
 1469 | ERROR | [x] Short array syntax must be used to define arrays
 1470 | ERROR | [x] Short array syntax must be used to define arrays
 1471 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
 1472 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
 1474 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
 1476 | ERROR | [x] Short array syntax must be used to define arrays
 1477 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
 1478 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
 1480 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
 1487 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
 1487 | ERROR | [x] Short array syntax must be used to define arrays
 1487 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
 1501 | ERROR | [x] Short array syntax must be used to define arrays
 1502 | ERROR | [x] Short array syntax must be used to define arrays
 1503 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
 1504 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
 1506 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
 1508 | ERROR | [x] Short array syntax must be used to define arrays
 1509 | ERROR | [x] Array double arrow not aligned correctly; expected 10 space(s) but found 1
 1510 | ERROR | [x] Array double arrow not aligned correctly; expected 8 space(s) but found 1
 1512 | ERROR | [x] Array double arrow not aligned correctly; expected 5 space(s) but found 1
 1519 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
 1519 | ERROR | [x] Short array syntax must be used to define arrays
 1519 | ERROR | [x] Only one argument is allowed per line in a multi-line function call
 1533 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 3 spaces
 1534 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space
 1535 | ERROR | [x] Short array syntax must be used to define arrays
 1565 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 3 spaces
 1566 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space
 1567 | ERROR | [x] Short array syntax must be used to define arrays
 1586 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 3 spaces
 1587 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space
 1588 | ERROR | [x] Short array syntax must be used to define arrays
 1607 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 3 spaces
 1608 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space
 1609 | ERROR | [x] Short array syntax must be used to define arrays
 1627 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 3 spaces
 1628 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space
 1629 | ERROR | [x] Short array syntax must be used to define arrays
 1646 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 3 spaces
 1647 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space
 1648 | ERROR | [x] Short array syntax must be used to define arrays
 1665 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 3 spaces
 1666 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space
 1667 | ERROR | [x] Short array syntax must be used to define arrays
 1684 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 3 spaces
 1685 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space
 1686 | ERROR | [x] Short array syntax must be used to define arrays
 1703 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 3 spaces
 1704 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space
 1705 | ERROR | [x] Short array syntax must be used to define arrays
 1720 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 3 spaces
 1721 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space
 1722 | ERROR | [x] Short array syntax must be used to define arrays
 1726 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 8 spaces but found 1 space
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 514 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------

@laemtl
Copy link
Contributor Author

laemtl commented Jul 9, 2020 •
edited
Loading 

./test/run-php-linter.sh -f
Fix mode set to true

PHPCBF RESULT SUMMARY
-------------------------------------------------------------------------
FILE                                                     FIXED  REMAINING
-------------------------------------------------------------------------
/var/www/html/loris/test/unittests/Database_Test.php     514    4
-------------------------------------------------------------------------
A TOTAL OF 514 ERRORS WERE FIXED IN 1 FILE
-------------------------------------------------------------------------

Time: 7.45 secs; Memory: 30MB

@laemtl laemtl force-pushed the 2020-07-08-lintfix-php branch from 5022434 to 9506e74 Compare July 9, 2020 22:17
@laemtl laemtl changed the base branch from master to main July 21, 2020 15:38
@laemtl laemtl force-pushed the 2020-07-08-lintfix-php branch from 9506e74 to 66b637a Compare July 21, 2020 19:26
@laemtl laemtl added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Aug 3, 2020
@laemtl laemtl force-pushed the 2020-07-08-lintfix-php branch from 66b637a to 6dd6c6d Compare August 3, 2020 22:52
@laemtl laemtl removed the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Aug 3, 2020
@laemtl laemtl added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Aug 17, 2020
@laemtl laemtl force-pushed the 2020-07-08-lintfix-php branch from 6dd6c6d to 50b432f Compare September 1, 2020 18:48
@laemtl laemtl removed the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Sep 1, 2020
@laemtl laemtl added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Oct 9, 2020
@laemtl laemtl force-pushed the 2020-07-08-lintfix-php branch 3 times, most recently from aa75747 to 79b8e80 Compare October 13, 2020 21:21
@laemtl laemtl removed the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Oct 13, 2020
@laemtl laemtl added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Nov 1, 2020
@laemtl laemtl force-pushed the 2020-07-08-lintfix-php branch from 79b8e80 to eff91b7 Compare December 12, 2020 00:28
@laemtl laemtl removed the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Dec 12, 2020
@laemtl
Copy link
Contributor Author

laemtl commented Dec 12, 2020

@kongtiaowang Ready for review

@laemtl laemtl added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Dec 14, 2020
@laemtl laemtl force-pushed the 2020-07-08-lintfix-php branch from eff91b7 to 4134aa5 Compare January 15, 2021 21:00
@laemtl laemtl removed the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Jan 15, 2021
@laemtl laemtl added Blocking PR should be prioritized because it is blocking the progress of another task and removed Proposal PR or issue suggesting an improvement that can be accepted, rejected or altered labels Jan 15, 2021
This was referenced Jan 15, 2021
Merged
Merged
kongtiaowang
kongtiaowang approved these changes Jan 16, 2021
View reviewed changes
Copy link
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kongtiaowang kongtiaowang added the Passed manual tests PR has been successfully tested by at least one peer label Jan 16, 2021
@driusan driusan merged commit 0a47beb into aces:main Jan 18, 2021
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this pull request Jun 29, 2021
@laemtl @AlexandraLivadas
[Test/Tools] Option in run-php-linter.sh to auto fix PHPCS (aces#6825)
3fa3b1c 
Add npm target to run phpcbf.
@ridz1208 ridz1208 added this to the 24.0.0 milestone Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kongtiaowang kongtiaowang kongtiaowang approved these changes

Assignees

@kongtiaowang kongtiaowang

@laemtl laemtl

Labels
Blocking PR should be prioritized because it is blocking the progress of another task Cleanup PR or issue introducing/requiring at least one clean-up operation Passed manual tests PR has been successfully tested by at least one peer Testing PR contains test plan or automated test code (or config files for Travis)
Projects
None yet
Milestone
24.0.0
Development

Successfully merging this pull request may close these issues.

[Tools/Test] Add support for PHPCBF with the defined set of rules
4 participants
@laemtl @kongtiaowang @driusan @ridz1208