Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Conflict Resolver] Multiselect values #7239

Merged

Conversation

laemtl
Copy link
Contributor

@laemtl laemtl commented Dec 17, 2020

Change the display of multi select values from value1{@}value2 to value1, value2 in the Correct Answer column of Unresolved and Resolved Conflicts.

@laemtl laemtl force-pushed the 2020-12-16-conflict-resolver-multiselect branch from 698ae0d to 44ce6d4 Compare December 17, 2020 01:26
@laemtl laemtl force-pushed the 2020-12-16-conflict-resolver-multiselect branch from 44ce6d4 to 9851fe7 Compare December 17, 2020 01:36
@sruthymathew123
Copy link
Contributor

sruthymathew123 commented Dec 21, 2020

@laemtl I tested on IBIS database and works well for multi select values already existing in the conflict resolver
Screen Shot 2020-12-21 at 3 51 00 PM

But I am addressing a small issue I noticed while testing this PR on IBIS. When I tried to create a new conflict(with 23.0 Release) with multi-select options, the values are getting saved as Array in the backend instead of value1{@}value2. IBIS is not updated with 23.0 version, so I don't know if it is an IBIS specific thing. But I just want to check if the multi-select values are saving correctly in the backend with 23.0.
@jesscall Can you just confirm if it is happening for CCNA on 23.0.

@sruthymathew123 sruthymathew123 added the Passed manual tests PR has been successfully tested by at least one peer label Dec 21, 2020
@laemtl
Copy link
Contributor Author

laemtl commented Dec 21, 2020

@sruthymathew123 The bug you reported is related to another issue. It occurred on CCNA and was fixed by adding

//Any LorisForm multiple selects must be listed here
$this->selectMultipleElements = array(
    'multi-select field name 1',
    ...
);

in the instrument setup function. If the previous Loris versions the method name was _selectMultipleElements (notice the undersore) and needs to be renamed selectMultipleElements otherwise it won't work.

@sruthymathew123
Copy link
Contributor

@laemtl Thanks for checking.

@driusan driusan merged commit bd6e68c into aces:23.0-release Dec 22, 2020
@ridz1208 ridz1208 added this to the 23.0.3 milestone Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed manual tests PR has been successfully tested by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[23.0][Conflict Resolver] Resolved Conflicts > Correct answer displays values incorrectly
4 participants