[permissions] Renaming and organizing permissions phase 0 #7327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridz1208
force-pushed
the
better_perms
branch
from
4ff13dd to
4834433
Compare
ridz1208
force-pushed
the
better_perms
branch
from
351e588 to
7a2e6ad
Compare
ridz1208
force-pushed
the
better_perms
branch
from
7a2e6ad to
5c31272
Compare
ridz1208
commented
Feb 6, 2021
| ] | ||
| ]; | ||
|
|
There was a problem hiding this comment.
I had to modify the test class to have the PR pass checks, the problem is, because I need toinstantiate a module to get its Long name, i resorted to use real modules (candidate_list and timepoint_list) which means I am king of breaking the rules of unit testing here because I am not only testing the getPermissionsVerbose() function but also the getActiveModulesIndexed() function of the module class. I know we should instead be using a mock module but I'm not sure how to do that. let me know if and how you want this PR changed
driusan
reviewed
Feb 8, 2021
kongtiaowang
added
the
Passed manual tests
driusan
previously requested changes
Feb 15, 2021
|
@driusan changes made, tests running |
|
@driusan anything still needed for this one ? you want someone else to review first ? |
|
I just re-skimmed it, but it looks good to me. |
driusan
pushed a commit
that referenced
this pull request
Apr 14, 2021
In PR #7327 the SQL patch for existing projects was missing the alter table statements that were required for the update statements to be run.
AlexandraLivadas
pushed a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 29, 2021
Add "actions" to and module to permissions table in order to harmonize and make the display of permissions in the frontend more consistent.
AlexandraLivadas
pushed a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 29, 2021
In PR aces#7327 the SQL patch for existing projects was missing the alter table statements that were required for the update statements to be run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
In an attempt to organise and standardise the existing permissions I have created a couple categories in the permissions table to leverage the modules architecture and add the
actioncolumn and generate the lable based on the combination of columns as a first phase.Changes in this PR:
new permissions......
