change parameter_file Value to longtext

[ycAbout]

Brief summary of changes

Add a sql patch to change parameter_file Value to longtext for upgrade.

Testing instructions (if applicable)

1. On a upgrade instance (upgraded from v21), check parameter_file table Value is text datatype (see also 21.0_to_22.0 upgrade)
2. Source mysql file on a upgrade instance (upgraded from v21)
3. Verify parameter_file table Value is longtext datatype, and your existing data is OK.

Link(s) to related issue(s)

• Resolves [SQL] parameter_file table inconsistency between new install and upgrade #7391
• Also resolves LORIS_MRI issue# 589

cc
@gdevenyi

[kongtiaowang]

LGTM

[kongtiaowang]

Loris/SQL/Release_patches/21.0_To_22.0_upgrade.sql

Line 38 in 11e6780

ALTER TABLE parameter_file MODIFY Value TEXT;

21.0_To_22.0_upgrade.sql has the issue, so it is better to modify the patch file directly.

[kongtiaowang]

need works

[driusan]

Why is this being changed?

[ycAbout]

ALTER TABLE parameter_file MODIFY Value TEXT;

OK I see your point. @kongtiaowang Your point would help the the following 2. I can add it later today.

1. For existing instance upgraded from v21 already, when they upgrade to v24, this new patch will do the work.
2. For new instance that is going to upgrade from v21 to v22 or v23 (but not v24), change 21.0_To_22.0_upgrade.sql would prevent the issue if they download the v24 (this patch goes into v24), also the new patch won't do any harm if they later upgrade to v24.

[ycAbout]

Why is this being changed?

Hi @driusan Please specifically see LORIS_MRI issue# 589, where I investigated the history of this issue.
Resolves #7391
Also resolves LORIS_MRI issue# 589

[kongtiaowang]

Hi @ycAbout SQL/New_patches/2021-03-15_change_parameter_file_Value_longtext.sql is good.
But "ALTER TABLE parameter_file MODIFY Value LONGTEXT;" should be here.
Just running one release patch file once，if user only wants to update Loris from 21 to 22.
release patch needs a new patch to update, that doesn't make sense.

[ycAbout]

Hi @kongtiaowang , I see what you mean. Without this line, user doesn't need to apply a v24 release patch to upgrade to v22. The reason to remove this line is that v18 already has this line handled. On the other hand, do the way you suggested won't do much harm. I can change it.

[kongtiaowang]

LGTM

[driusan]

This should not modify the release patch for a release that already exists.

[ycAbout]

This should not modify the release patch for a release that already exists.

OK,
It seems that both @kongtiaowang and @driusan have a point. Given that Dave is more senior, I think we should follow @driusan, what do you think, @kongtiaowang ?

[ycAbout]

The change has been reverted, so there is no modification of released patches. @driusan