-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[candidate_parameters] Allow clearing of consent status #7772
Conversation
Hi @CamilleBeau the consent fields revert back to the previous values after clicking the "Update" button. then selecting empty field for response: then after clicking the Update button: I might be mistaken but I don't think that's intended? |
d780051
to
70b558f
Compare
@maltheism Rebased! I tested this again on my VM and I was not able to replicate the problem you mentioned: Clearing value & pressing submit: It stayed clear after refreshing as well. Would you be able to re-test it now that I've rebased? |
Does anyone have insight on the test suite failures here? |
@kongtiaowang can you help @CamilleBeau resolves the test failures please? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and looks good
Brief summary of changes
This PR allows users to set a consent status back to null. I chose not to do this with a "Clear" button because a clear button would mean you are clearing all or none of the consent statuses on the page, or otherwise we would need a clear button for each individual consent. Instead, the participant can set the status to be empty and update the consent as usual. The date and withdrawal date are cleared and disabled when the status is set back to empty.
Testing instructions (if applicable)
Link(s) to related issue(s)