Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue_tracker] Resolves special characters in titles #8842

Merged
merged 2 commits into from
Aug 16, 2023
Merged

[issue_tracker] Resolves special characters in titles #8842

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e79eaa9
issue_tracker - resolve special characters in title
Jul 19, 2023
df1a7e1
issue_tracker - use unsafe inserts/updates
Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions modules/issue_tracker/php/edit.class.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,11 +447,11 @@ class Edit extends \NDB_Page implements ETagCalculator
$historyValues = $this->getChangedValues($issueValues, $issueID, $user);

if (!empty($issueID)) {
$db->update('issues', $issueValues, ['issueID' => $issueID]);
$db->unsafeUpdate('issues', $issueValues, ['issueID' => $issueID]);
} else {
$issueValues['reporter'] = $user->getUsername();
$issueValues['dateCreated'] = date('Y-m-d H:i:s');
$db->insert('issues', $issueValues);
$db->unsafeInsert('issues', $issueValues);
$issueID = intval($db->getLastInsertId());
}

Expand Down Expand Up @@ -815,7 +815,7 @@ class Edit extends \NDB_Page implements ETagCalculator
'issueID' => $issueID,
'addedBy' => $user->getUsername(),
];
$db->insert('issues_history', $changedValues);
$db->unsafeInsert('issues_history', $changedValues);
}
}
}
Expand All @@ -838,7 +838,7 @@ class Edit extends \NDB_Page implements ETagCalculator
'addedBy' => $user->getUsername(),
'issueID' => $issueID,
];
$db->insert('issues_comments', $commentValues);
$db->unsafeInsert('issues_comments', $commentValues);
}
}

Expand Down