[Instruments] Handle empty bulkLoadInstanceData #8857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic of bulkLoadInstanceData constructs an SQL statement with the parameters bound to it by looping over the iterable passed to it. If the iterable is empty, the result will generate SQL with the string `.. IN ()` which is not valid SQL. This returns an empty array in that case before attempting to generate the SQL, since the result of bulk loading nothing should be nothing.
driusan
added
Category: Bug
ridz1208
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic of bulkLoadInstanceData constructs an SQL statement with the parameters bound to it by looping over the iterable passed to it. If the iterable is empty, the result will be SQL with the string
.. IN ()which is not valid SQL. This returns an empty array in that case before attempting to run the generated SQL, since the result of bulk loading nothing should be nothing.