Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bvl_feedback] Update summary in real time #8966

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

CamilleBeau
Copy link
Contributor

@CamilleBeau CamilleBeau commented Nov 21, 2023

Brief summary of changes

This PR fixes the bvl_feedback module to update the summary in real time after opening or closing feedbacks. The PR also fixes a Unexpected end to json input react error when opening and closing feedbacks by changing the success response to a json response.

  • Have you updated related documentation?

Testing instructions (if applicable)

  1. Off of the main branch, load the bvl_feedback module by clicking the edit icon in the top right of a candidate, visit, or instrument page.
  2. Save a few new feedbacks, and notice that the number of open feedbacks in the summary at the top increases every time you save a feedback.
  3. Open and close a few feedbacks, and notice that if you open a closed feedback, it still shows as closed until you refresh the page. The summary at the top also does not change until you refresh the page.
  4. Load this PR and repeat the previous steps.
  5. Make sure that from this PR, the summary at the top is updated in real time.
  6. Also make sure that if you open or close a feedback, they are immediately shown as open or closed instead of having to refresh.

Link(s) to related issue(s)

@racostas racostas self-requested a review December 1, 2023 05:18
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@racostas racostas added the Passed manual tests PR has been successfully tested by at least one peer label Dec 1, 2023
@driusan driusan merged commit 9928c54 into aces:main Dec 1, 2023
19 checks passed
@ridz1208 ridz1208 added this to the 26.0.0 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed manual tests PR has been successfully tested by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bvl_feedback] # of threads in table not automatically updated after closing a thread
4 participants