Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dicom archive] Fix dicom archive details links #9081

Merged
merged 1 commit into from
Mar 11, 2024
Merged

[dicom archive] Fix dicom archive details links #9081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 0 additions & 53 deletions modules/dicom_archive/js/view_details_link.js
View file
Open in desktop

This file was deleted.

19 changes: 0 additions & 19 deletions modules/dicom_archive/php/viewdetails.class.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,24 +357,6 @@ class ViewDetails extends \NDB_Form
);
}

/**
* Overrides base getJSDependencies() to add additional JS files
*
* @return array of extra JS files that this page depends on
*/
function getJSDependencies()
{
$factory = \NDB_Factory::singleton();
$baseURL = $factory->settings()->getBaseURL();
$deps = parent::getJSDependencies();
return array_merge(
$deps,
[
$baseURL . "/dicom_archive/js/view_details_link.js",
]
);
}

/**
* Generate a breadcrumb trail for this page.
*
Expand All @@ -392,4 +374,3 @@ class ViewDetails extends \NDB_Form
);
}
}

9 changes: 3 additions & 6 deletions modules/dicom_archive/templates/form_viewDetails.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@
<tr>
<th>Acquisition ID</th>
<td>
<a class="dicom_archive" style="cursor: pointer"
data-patientname="{$archive.PatientName}">
{$archive.DicomArchiveID}
<a href="/mri_violations?patientName={$archive.PatientName}">
{$archive.DicomArchiveID}
</a>
</td>
</tr>
Expand Down Expand Up @@ -124,9 +123,7 @@
<td>{$archive_series[record].PhaseEncoding}</td>
<td>{$archive_series[record].NumberOfFiles}</td>
<td>
<a href="#" class="dicom_archive"
data-patientname="{$archive.PatientName}"
data-seriesuid="{$archive_series[record].SeriesUID}">
<a href="/mri_violations?patientName={$archive.PatientName}&seriesUID={$archive_series[record].SeriesUID}">
{$archive_series[record].SeriesUID}
</a>
</td>
Expand Down
Loading