Defining default decimal point for non JSON table LINST instruments #9277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR forces the
decimal(14,4)
(10 digits on the integer part, and 4 digits on the floating point part), instead ofdecimal(10,0)
which is the default fornumeric
and was truncating floating point digits.It only applies this change for instruments that require their own table (non JSON) and have
numeric
attribute.Testing instructions (if applicable)
tools/generate_tables_sql.php
andtools/generate_tables_sql_and_testNames.php
with a non JSON LINST instrument with at least anumeric
type line.decimal(14,4)
type for the numeric attribute, instead of anumeric
attribute.Link(s) to related issue(s)
Resolves #9237