Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Project Affiliations Menu to Menu Bar #9405

Closed
wants to merge 4 commits into from

Conversation

NadaElmasry
Copy link
Collaborator

Changes Implemented

  1. User Class

    • Updated the User class to retrieve associated projects using the user's ID.
  2. Main Template

    • Added a new Project Affiliations menu item to the main template.
    • Expanded the existing Affiliations Menu to include a Project Affiliations section.
  3. User Page Middleware

    • Updated the user page middleware to incorporate the newly fetched project affiliations from the User class.

Current Main Page View

projectaffiliations1
projectaffiliations2

Related Issue

@laemtl
Copy link
Contributor

laemtl commented Oct 11, 2024

@NadaElmasry You introduced a lot of changes in the User class . Some of them are the reason you have failed Unit tests.

@laemtl
Copy link
Contributor

laemtl commented Oct 11, 2024

You have the following static errors:

FILE: /home/runner/work/Loris/Loris/php/libraries/User.class.inc
----------------------------------------------------------------------
FOUND 5 ERRORS AND 3 WARNINGS AFFECTING 8 LINES
----------------------------------------------------------------------
  36 | ERROR   | [x] Tag value for @var tag indented incorrectly;
     |         |     expected 4 spaces but found 1
  68 | ERROR   | [x] Equals sign not aligned with surrounding
     |         |     assignments; expected 3 spaces but found 1 space
 125 | ERROR   | [x] Equals sign not aligned with surrounding
     |         |     assignments; expected 6 spaces but found 1 space
 130 | ERROR   | [x] Equals sign not aligned with surrounding
     |         |     assignments; expected 2 spaces but found 1 space
 1[36](https://github.com/aces/Loris/pull/9405/checks#step:11:37) | ERROR   | [x] Equals sign not aligned with surrounding
     |         |     assignments; expected 3 spaces but found 1 space
 165 | WARNING | [ ] Line exceeds 85 characters; contains 115
     |         |     characters
 249 | WARNING | [ ] Line exceeds 85 characters; contains 106
     |         |     characters
 253 | WARNING | [ ] Line exceeds 85 characters; contains 98
     |         |     characters
----------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

@laemtl
Copy link
Contributor

laemtl commented Oct 18, 2024

@NadaElmasry Can we remove all the User class changes except the ones needed for the feature?

*
* @category Main
* @package Main
* @author Alex Zijdenbos <zijdenbos@example.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes like this (by your IDE) are cluttering -- we'd like to see just what you changed (as discussed Friday).
@NadaElmasry if you need help with next steps here please let us know ASAP

@NadaElmasry NadaElmasry deleted the project-affiliations branch October 21, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants